Bug 236043 – REGRESSION(r288878) webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests tests are failing with Windows Python

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Fujii Hironori]

REGRESSION(r288878) webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests tests are failing with Windows Python

Since r288878 (Bug 235370)
WinCairo buildbot is using Windows Python.
https://build.webkit.org/#/builders/60/builds/4301


[496/1640] webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests.test_find_all_no_paths
[497/1640] webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests.test_find_all_no_paths passed
[497/1640] webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests.test_find_directory
[498/1640] webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests.test_find_directory failed:
  Traceback (most recent call last):
    File "C:\BW\wincairo-wkl-release-tests\build\Tools\Scripts\webkitpy\layout_tests\controllers\layout_test_finder_legacy_unittest.py", line 263, in test_find_directory
      self.assertEqual(tests, ['websocket/tests/passes/text.html'])
  AssertionError: Lists differ: ['\\test.checkout\\LayoutTests\\websocket\\tests\\passes\\text.html'] != ['websocket/tests/passes/text.html']
  
  First differing element 0:
  '\\test.checkout\\LayoutTests\\websocket\\tests\\passes\\text.html'
  'websocket/tests/passes/text.html'
  
  - ['\\test.checkout\\LayoutTests\\websocket\\tests\\passes\\text.html']
  + ['websocket/tests/passes/text.html']
  
[498/1640] webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests.test_find_directory_includes_platform_specific
[499/1640] webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests.test_find_directory_includes_platform_specific failed:
  Traceback (most recent call last):
    File "C:\BW\wincairo-wkl-release-tests\build\Tools\Scripts\webkitpy\layout_tests\controllers\layout_test_finder_legacy_unittest.py", line 173, in test_find_directory_includes_platform_specific
      self.assertEqual(
  AssertionError: Lists differ: ['\\test.checkout\\LayoutTests\\http\\tests[142 chars]tml'] != ['http/tests/passes/image.html', 'http/test[87 chars]tml']
  
  First differing element 0:
  '\\test.checkout\\LayoutTests\\http\\tests\\passes\\image.html'
  'http/tests/passes/image.html'
  
  Second list contains 1 additional elements.
  First extra element 3:
  'platform/test-mac-leopard/http/test.html'
  
  - ['\\test.checkout\\LayoutTests\\http\\tests\\passes\\image.html',
  -  '\\test.checkout\\LayoutTests\\http\\tests\\passes\\text.html',
  -  '\\test.checkout\\LayoutTests\\http\\tests\\ssl\\text.html']
  + ['http/tests/passes/image.html',
  +  'http/tests/passes/text.html',
  +  'http/tests/ssl/text.html',
  +  'platform/test-mac-leopard/http/test.html']
  
[499/1640] webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests.test_find_directory_multiple_times

[Fujii Hironori]

Created attachment 450715 [details]
Patch

[Sam Sneddon [:gsnedders]]

Ah, gah, sorry about this regression! I'd actually realised I was breaking the tests in this way and had worked around it locally (essentially by maintaining the existing semantics of always running the tests under an emulated UNIX-like filesystem), but clearly I uploaded an outdated patch. This is, however, undoubtedly better, given you're fixing the actual reason for the failure!

[Fujii Hironori]

Comment on attachment 450715 [details]
Patch

Thank you for the review.

[EWS]

Committed r289067 (246774@main): <https://commits.webkit.org/246774@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450715 [details].

[Radar WebKit Bug Importer]

<rdar://problem/88449289>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 236149

[Fujii Hironori]

Created attachment 451058 [details]
Patch

[EWS]

Committed r289197 (246883@main): <https://commits.webkit.org/246883@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451058 [details].