Bug 236041 - Improve color contrast of dark mode syntax highlighting
Summary: Improve color contrast of dark mode syntax highlighting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Davis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-02 14:46 PST by Jon Davis
Modified: 2022-02-02 16:33 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.70 KB, patch)
2022-02-02 15:08 PST, Jon Davis 		no flags Details | Formatted Diff | Diff
Before patch is applied (52.70 KB, image/png)
2022-02-02 15:09 PST, Jon Davis 		no flags Details
After patch applied (56.03 KB, image/png)
2022-02-02 15:10 PST, Jon Davis 		no flags Details
Patch (3.35 KB, patch)
2022-02-02 15:41 PST, Jon Davis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2022-02-02 14:46:07 PST 
The code block syntax highlighting in dark mode needs better contrast.
Comment 1 Jon Davis 2022-02-02 15:08:34 PST 
Created attachment 450701 [details]
Patch
Comment 2 Jon Davis 2022-02-02 15:09:36 PST 
Created attachment 450702 [details]
Before patch is applied
Comment 3 Jon Davis 2022-02-02 15:10:00 PST 
Created attachment 450703 [details]
After patch applied
Comment 4 Simon Fraser (smfr) 2022-02-02 15:17:10 PST 
Comment on attachment 450701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450701&action=review

> Websites/webkit.org/ChangeLog:20
> +2022-02-02  Jon Davis  <jond@apple.com>
> +
> +        Improve color contrast of dark mode syntax highlighting.
> +        https://bugs.webkit.org/show_bug.cgi?id=236041
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * wp-content/themes/webkit/style.css:
> +        (@media(prefers-color-scheme:dark) :root):

Double changelog.
Comment 5 Myles C. Maxfield 2022-02-02 15:17:25 PST 
Comment on attachment 450701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450701&action=review

> Websites/webkit.org/ChangeLog:20
> +2022-02-02  Jon Davis  <jond@apple.com>
> +
> +        Improve color contrast of dark mode syntax highlighting
> +        https://bugs.webkit.org/show_bug.cgi?id=236041
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * wp-content/themes/webkit/search.php: Added.
> +        * wp-content/themes/webkit/style.css:
> +        (@media(prefers-color-scheme:dark) :root):
> +
> +2022-02-02  Jon Davis  <jond@apple.com>
> +
> +        Improve color contrast of dark mode syntax highlighting.
> +        https://bugs.webkit.org/show_bug.cgi?id=236041
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * wp-content/themes/webkit/style.css:
> +        (@media(prefers-color-scheme:dark) :root):

Ideally this wouldn't be duplicated.
Comment 6 Jon Davis 2022-02-02 15:41:34 PST 
Created attachment 450707 [details]
Patch
Comment 7 EWS 2022-02-02 16:32:04 PST 
Committed r289013 (246722@main): <https://commits.webkit.org/246722@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450707 [details].
Comment 8 Radar WebKit Bug Importer 2022-02-02 16:33:18 PST 
<rdar://problem/88408169>