Move connect event dispatch logic to SharedWorkerGlobalScope and add logging.
Created attachment 450696 [details] Patch
Comment on attachment 450696 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450696&action=review > Source/WebCore/workers/shared/SharedWorkerGlobalScope.cpp:68 > + auto serializedScriptValue = SerializedScriptValue::create(""); emptyString()? Shorter variable name? Maybe serializedValue or even just value? > Source/WebCore/workers/shared/SharedWorkerGlobalScope.h:28 > +#include "MessageWithMessagePorts.h" Do we really need this header? No way to forward declare TransferredMessagePort instead?
(In reply to Darin Adler from comment #2) > Comment on attachment 450696 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450696&action=review > > > Source/WebCore/workers/shared/SharedWorkerGlobalScope.cpp:68 > > + auto serializedScriptValue = SerializedScriptValue::create(""); > > emptyString()? > > Shorter variable name? Maybe serializedValue or even just value? > > > Source/WebCore/workers/shared/SharedWorkerGlobalScope.h:28 > > +#include "MessageWithMessagePorts.h" > > Do we really need this header? No way to forward declare > TransferredMessagePort instead? Once Bug 236028 lands, I'll be able to include TransferredMessagePort.h instead which will be an improvement. I don't think I can conveniently forward-declare though since this is basically a typedef to a std::pair<MessagePortIdentifier, MessagePortIdentifier>. I will wait for Bug 236028 before landing this one, so I can fix the include.
Created attachment 450706 [details] Patch
Committed r289023 (246731@trunk): <https://commits.webkit.org/246731@trunk>
<rdar://problem/88412313>