Bug 236017 - Move SharedWorkerThread & SharedWorkerProxy to workers/shared/context/
Summary: Move SharedWorkerThread & SharedWorkerProxy to workers/shared/context/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 235958
  Show dependency tree / graph
 
Reported: 2022-02-02 08:09 PST by Chris Dumez
Modified: 2022-02-02 11:58 PST (History)
11 users (show)

See Also:

Attachments
Patch (50.82 KB, patch)
2022-02-02 08:35 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (50.87 KB, patch)
2022-02-02 09:13 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-02-02 08:09:12 PST 
Move SharedWorkerThread & SharedWorkerProxy to workers/shared/context/, for consistency with service workers. Also rename SharedWorkerProxy to SharedWorkerThreadProxy.
Comment 1 Chris Dumez 2022-02-02 08:35:18 PST 
Created attachment 450646 [details]
Patch
Comment 2 youenn fablet 2022-02-02 08:58:44 PST 
Comment on attachment 450646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450646&action=review

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp:112
> +    m_scriptExecutionContext->postTask([this] (ScriptExecutionContext&) {

s/ScriptExecutionContext/auto/.
Are we sure this is valid?
Maybe add a comment stating why.

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:40
> +class SharedWorkerThreadProxy : public ThreadSafeRefCounted<SharedWorkerThreadProxy>, public WorkerGlobalScopeProxy, public WorkerObjectProxy, public WorkerLoaderProxy, public WorkerDebuggerProxy {

final?

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:65
> +    void setResourceCachingDisabledByWebInspector(bool) final;

Can they be made private?

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:68
> +    SharedWorkerThreadProxy(SharedWorker&);

explicit.
Comment 3 Chris Dumez 2022-02-02 09:00:57 PST 
(In reply to youenn fablet from comment #2)
> Comment on attachment 450646 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450646&action=review
> 
> > Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp:112
> > +    m_scriptExecutionContext->postTask([this] (ScriptExecutionContext&) {
> 
> s/ScriptExecutionContext/auto/.
> Are we sure this is valid?
> Maybe add a comment stating why.
> 
> > Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:40
> > +class SharedWorkerThreadProxy : public ThreadSafeRefCounted<SharedWorkerThreadProxy>, public WorkerGlobalScopeProxy, public WorkerObjectProxy, public WorkerLoaderProxy, public WorkerDebuggerProxy {
> 
> final?
> 
> > Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:65
> > +    void setResourceCachingDisabledByWebInspector(bool) final;
> 
> Can they be made private?
> 
> > Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:68
> > +    SharedWorkerThreadProxy(SharedWorker&);
> 
> explicit.

These classes change *significantly* in the next patch at Bug 235958 but OK.
Comment 4 Chris Dumez 2022-02-02 09:13:35 PST 
Created attachment 450657 [details]
Patch
Comment 5 Chris Dumez 2022-02-02 11:57:00 PST 
Comment on attachment 450657 [details]
Patch

Clearing flags on attachment: 450657

Committed r288975 (246704@trunk): <https://commits.webkit.org/246704@trunk>
Comment 6 Chris Dumez 2022-02-02 11:57:04 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2022-02-02 11:58:18 PST 
<rdar://problem/88393944>