Bug 236017 – Move SharedWorkerThread & SharedWorkerProxy to workers/shared/context/

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Move SharedWorkerThread & SharedWorkerProxy to workers/shared/context/, for consistency with service workers. Also rename SharedWorkerProxy to SharedWorkerThreadProxy.

[Chris Dumez]

Created attachment 450646 [details]
Patch

[youenn fablet]

Comment on attachment 450646 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450646&action=review

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp:112
> +    m_scriptExecutionContext->postTask([this] (ScriptExecutionContext&) {

s/ScriptExecutionContext/auto/.
Are we sure this is valid?
Maybe add a comment stating why.

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:40
> +class SharedWorkerThreadProxy : public ThreadSafeRefCounted<SharedWorkerThreadProxy>, public WorkerGlobalScopeProxy, public WorkerObjectProxy, public WorkerLoaderProxy, public WorkerDebuggerProxy {

final?

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:65
> +    void setResourceCachingDisabledByWebInspector(bool) final;

Can they be made private?

> Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:68
> +    SharedWorkerThreadProxy(SharedWorker&);

explicit.

[Chris Dumez]

(In reply to youenn fablet from comment #2)
> Comment on attachment 450646 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450646&action=review
> 
> > Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp:112
> > +    m_scriptExecutionContext->postTask([this] (ScriptExecutionContext&) {
> 
> s/ScriptExecutionContext/auto/.
> Are we sure this is valid?
> Maybe add a comment stating why.
> 
> > Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:40
> > +class SharedWorkerThreadProxy : public ThreadSafeRefCounted<SharedWorkerThreadProxy>, public WorkerGlobalScopeProxy, public WorkerObjectProxy, public WorkerLoaderProxy, public WorkerDebuggerProxy {
> 
> final?
> 
> > Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:65
> > +    void setResourceCachingDisabledByWebInspector(bool) final;
> 
> Can they be made private?
> 
> > Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h:68
> > +    SharedWorkerThreadProxy(SharedWorker&);
> 
> explicit.

These classes change *significantly* in the next patch at Bug 235958 but OK.

[Chris Dumez]

Created attachment 450657 [details]
Patch

[Chris Dumez]

Comment on attachment 450657 [details]
Patch

Clearing flags on attachment: 450657

Committed r288975 (246704@trunk): <https://commits.webkit.org/246704@trunk>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/88393944>