Bug 236016 – Move and rename ServiceWorkerFrameLoaderClient & ServiceWorkerLibWebRTCProvider

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[Chris Dumez]

Move and rename ServiceWorkerFrameLoaderClient & ServiceWorkerLibWebRTCProvider so that they can be reused by Shared Workers.

[Chris Dumez]

Created attachment 450644 [details]
Patch

[youenn fablet]

Comment on attachment 450644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450644&action=review

> Source/WebCore/loader/FrameLoaderClient.h:354
> +    virtual bool isWebWorkerFrameLoaderClient() const { return false; }

Not sure WebWorker is a great name given DedicatedWorker would seem to fit there.
Not sure I have a better name though, maybe RemoteWorker.

[Chris Dumez]

(In reply to youenn fablet from comment #2)
> Comment on attachment 450644 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450644&action=review
> 
> > Source/WebCore/loader/FrameLoaderClient.h:354
> > +    virtual bool isWebWorkerFrameLoaderClient() const { return false; }
> 
> Not sure WebWorker is a great name given DedicatedWorker would seem to fit
> there.
> Not sure I have a better name though, maybe RemoteWorker.

My point of view was that:
1. Web is the usual prefix at the WebKit layer
2. This class could be used in theory with any type of worker (yes even dedicated ones) although there isn't any point in using it for dedicated workers since they are fully at the WebCore layer at the moment.

[Chris Dumez]

That said, the RemoteWorker naming is growing on me :)

[Chris Dumez]

Created attachment 450647 [details]
Patch

[Chris Dumez]

(In reply to Chris Dumez from comment #4)
> That said, the RemoteWorker naming is growing on me :)

Adopted before landing.

[Chris Dumez]

Created attachment 450658 [details]
Patch

[Chris Dumez]

Comment on attachment 450658 [details]
Patch

Clearing flags on attachment: 450658

Committed r288972 (246701@trunk): <https://commits.webkit.org/246701@trunk>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/88391416>