Bug 236016 - Move and rename ServiceWorkerFrameLoaderClient & ServiceWorkerLibWebRTCProvider
Summary: Move and rename ServiceWorkerFrameLoaderClient & ServiceWorkerLibWebRTCProvider
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 235958
  Show dependency tree / graph
 
Reported: 2022-02-02 07:44 PST by Chris Dumez
Modified: 2022-02-02 12:01 PST (History)
7 users (show)

See Also:

Attachments
Patch (27.04 KB, patch)
2022-02-02 07:56 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (27.23 KB, patch)
2022-02-02 08:45 PST, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (27.32 KB, patch)
2022-02-02 09:17 PST, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-02-02 07:44:14 PST 
Move and rename ServiceWorkerFrameLoaderClient & ServiceWorkerLibWebRTCProvider so that they can be reused by Shared Workers.
Comment 1 Chris Dumez 2022-02-02 07:56:27 PST 
Created attachment 450644 [details]
Patch
Comment 2 youenn fablet 2022-02-02 08:19:25 PST 
Comment on attachment 450644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450644&action=review

> Source/WebCore/loader/FrameLoaderClient.h:354
> +    virtual bool isWebWorkerFrameLoaderClient() const { return false; }

Not sure WebWorker is a great name given DedicatedWorker would seem to fit there.
Not sure I have a better name though, maybe RemoteWorker.
Comment 3 Chris Dumez 2022-02-02 08:21:14 PST 
(In reply to youenn fablet from comment #2)
> Comment on attachment 450644 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450644&action=review
> 
> > Source/WebCore/loader/FrameLoaderClient.h:354
> > +    virtual bool isWebWorkerFrameLoaderClient() const { return false; }
> 
> Not sure WebWorker is a great name given DedicatedWorker would seem to fit
> there.
> Not sure I have a better name though, maybe RemoteWorker.

My point of view was that:
1. Web is the usual prefix at the WebKit layer
2. This class could be used in theory with any type of worker (yes even dedicated ones) although there isn't any point in using it for dedicated workers since they are fully at the WebCore layer at the moment.
Comment 4 Chris Dumez 2022-02-02 08:23:36 PST 
That said, the RemoteWorker naming is growing on me :)
Comment 5 Chris Dumez 2022-02-02 08:45:08 PST 
Created attachment 450647 [details]
Patch
Comment 6 Chris Dumez 2022-02-02 08:45:40 PST 
(In reply to Chris Dumez from comment #4)
> That said, the RemoteWorker naming is growing on me :)

Adopted before landing.
Comment 7 Chris Dumez 2022-02-02 09:17:03 PST 
Created attachment 450658 [details]
Patch
Comment 8 Chris Dumez 2022-02-02 11:13:34 PST 
Comment on attachment 450658 [details]
Patch

Clearing flags on attachment: 450658

Committed r288972 (246701@trunk): <https://commits.webkit.org/246701@trunk>
Comment 9 Chris Dumez 2022-02-02 11:13:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2022-02-02 11:14:17 PST 
<rdar://problem/88391416>