Bug 236012 – [Forms] change the default appearance of button, checkbox etc. to 'auto'

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

Affected WPT test 

imported/w3c/web-platform-tests/html/rendering/widgets/appearance/default-styles.html

[Radar WebKit Bug Importer]

<rdar://problem/88684058>

Created attachment 456357 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 456357 [details]
Patch

According to EWS you need to delete: LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/rendering/widgets/appearance/default-styles-expected.txt


and rebaseline: LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/appearance/default-styles-expected.txt (though why can't we use auto on iOS as well in the failing cases?)

Created attachment 456548 [details]
Patch

Created attachment 456549 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 456549 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456549&action=review

Can https://webkit-search.igalia.com/webkit/rev/81b1b504044f756417974ca63b3992ee817bb619/Source/WebCore/css/html.css#759 be changed to `appearance: initial`?

Also, https://webkit-search.igalia.com/webkit/rev/81b1b504044f756417974ca63b3992ee817bb619/Source/WebCore/rendering/RenderTheme.cpp#333-440 suggests there's more in that UA stylesheet that can be switched over to `appearance: auto` (input::-webkit-caps-lock-indicator for instance, among many examples). Can you do that either here or in a new bug?

> Source/WebCore/css/html.css:500
> -    -webkit-appearance: textfield;
> +    appearance: auto;
>      align-items: center;
>      display: -webkit-inline-flex;
>      overflow: hidden;
>  #if defined(WTF_PLATFORM_IOS_FAMILY) && WTF_PLATFORM_IOS_FAMILY
> -    -webkit-appearance: menulist-button;
> +    appearance: auto;
>      border: 1px solid -webkit-control-background;
>      background-color: -apple-system-opaque-secondary-fill;
>      font-family: system-ui;
>      color: -apple-system-blue;
>      padding: 0.2em 0.5em;
>  #else
> -    -webkit-appearance: textfield;
> +    appearance: auto;

The last 2 are redundant, can you remove them?

> Source/WebCore/css/html.css:1048
> +    appearance: auto;

You can move this out of the #if / #else and remove this property and the one above.

> LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/rendering/widgets/appearance/default-styles-expected.txt:17
>  FAIL <input type="color"> assert_equals: -webkit-appearance expected "auto" but got "color-well"

You should be able to get rid of this iOS test results file by changing: https://webkit-search.igalia.com/webkit/rev/81b1b504044f756417974ca63b3992ee817bb619/Source/WebCore/rendering/RenderThemeIOS.mm#2602 directly

Created attachment 456560 [details]
Patch

Created attachment 456561 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 456561 [details]
Patch

r=me if EWS is happy

[Tim Nguyen (:ntim)]

The issue with fast/attachment/attachment-disabled-rendering.html is that `appearance: attachment` is unconditionally added (even when the <attachment> element is disabled), causing the `display` to become `inline-block` here: https://webkit-search.igalia.com/webkit/rev/81b1b504044f756417974ca63b3992ee817bb619/Source/WebCore/rendering/RenderTheme.cpp#128-136

The new behavior checks for HTMLAttachmentElement (which actually takes in consideration whether the <attachment> element is enabled or not), since it is disabled in the test, appearance: auto computes to none, and the codepath above is never hit, meaning the element stays `display: inline`.

The new behavior is more correct, so I suggest to simply rebaseline the results for that test.

[Tim Nguyen (:ntim)]

(In reply to Tim Nguyen (:ntim) from comment #10)
> The issue with fast/attachment/attachment-disabled-rendering.html is that
> `appearance: attachment` is unconditionally added (even when the
> <attachment> element is disabled)

Filed https://bugs.webkit.org/show_bug.cgi?id=238739 for this.

[Tim Nguyen (:ntim)]

Rebasing on top of bug 238739 should fix the remaining failures.

Created attachment 456597 [details]
Patch

Created attachment 456599 [details]
Patch

Created attachment 456602 [details]
Patch

Created attachment 456603 [details]
[fast-cq] Patch

[EWS]

Committed r292376 (249241@main): <https://commits.webkit.org/249241@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456603 [details].