Bug 236008 – Enable overflow:clip feature

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Rob Buis]

Enable overflow:clip feature.

[Rob Buis]

Created attachment 450626 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/88387256>

[Arcady Goldmints-Orlov]

Would it make sense to also unskip the tests still marked as skips and tagged with bug 198230? I.e. 

webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/clip-003.html [ Skip ]
webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-intersection-observer.html [ Skip ]
webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-invalidation.html [ Skip ]
webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-001.html [ Skip ]
webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-002.html [ Skip ]
webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-003.html [ Skip ]
webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-004.html [ Skip ]
webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-005.html [ Skip ]
webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-006.html [ Skip ]
webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-007.html [ Skip ]

[EWS]

Committed r288973 (246702@main): <https://commits.webkit.org/246702@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450626 [details].

[Rob Buis]

(In reply to Arcady Goldmints-Orlov from comment #3)
> Would it make sense to also unskip the tests still marked as skips and
> tagged with bug 198230? I.e. 
> 
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/clip-003.html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-
> intersection-observer.html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-
> invalidation.html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-001.
> html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-002.
> html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-003.
> html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-004.
> html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-005.
> html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-006.
> html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-007.
> html [ Skip ]

I think that is independent of this bug. i.e. they should pass (or not) independent of setting on by default (or not), as the tests should be run with experimental flags enabled.

[Rob Buis]

(In reply to Arcady Goldmints-Orlov from comment #3)
> Would it make sense to also unskip the tests still marked as skips and
> tagged with bug 198230? I.e. 
> 
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/clip-003.html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-
> intersection-observer.html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-
> invalidation.html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-001.
> html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-002.
> html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-003.
> html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-004.
> html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-005.
> html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-006.
> html [ Skip ]
> webkit.org/b/198230
> imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-007.
> html [ Skip ]

Now that I look closer, we do not support the overflow-clip-margin property so most of these should not pass. If clip-003.html passes then I am in favour of not skipping it. In general I think we may not be aggressive enough regarding enabling tests, many times I see "unexpected pass" locally.

[Simon Fraser (smfr)]

Do we have a bug to implement overflow-clip-margin?

[Rob Buis]

(In reply to Simon Fraser (smfr) from comment #7)
> Do we have a bug to implement overflow-clip-margin?

I could not find anything relevant, so I created https://bugs.webkit.org/show_bug.cgi?id=236153.