Bug 236002 - Rename FontCascade::spaceWidth() to FontCascade::spaceWidthOfPrimaryFont()
Summary: Rename FontCascade::spaceWidth() to FontCascade::spaceWidthOfPrimaryFont()
Status: RESOLVED DUPLICATE of bug 236007
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-01 22:02 PST by Myles C. Maxfield
Modified: 2022-02-01 23:55 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.63 KB, patch)
2022-02-01 22:04 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (5.03 KB, patch)
2022-02-01 22:24 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-02-01 22:02:17 PST 
Rename FontCascade::spaceWidth() to FontCascade::spaceWidthOfPrimaryFont()
Comment 1 Myles C. Maxfield 2022-02-01 22:04:20 PST 
Created attachment 450609 [details]
Patch
Comment 2 Myles C. Maxfield 2022-02-01 22:24:02 PST 
Created attachment 450612 [details]
Patch
Comment 3 Myles C. Maxfield 2022-02-01 23:00:25 PST 
Comment on attachment 450612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450612&action=review

> Source/WebCore/platform/graphics/FontCascade.h:167
> +    float spaceWidthOfPrimaryFont() const { return primaryFont().spaceWidth() + m_letterSpacing; }

This probably isn't a great name, because it includes letter spacing.
Comment 4 Myles C. Maxfield 2022-02-01 23:55:21 PST 

*** This bug has been marked as a duplicate of bug 236007 ***