This runtime flag is always on.
Created attachment 450598 [details] Patch
Comment on attachment 450598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450598&action=review > Source/WebCore/editing/gtk/EditorGtk.cpp:120 > + pasteboardContent.markup = serializePreservingVisualAppearance(m_document.selection().selection(), ResolveURLs::YesExcludingLocalFileURLsForPrivacy, SerializeComposedTree::Yes : SerializeComposedTree::No); Editing mistake here. Left behind “: SerializedComposedTree::No”. > Source/WebCore/editing/libwpe/EditorLibWPE.cpp:68 > + pasteboardContent.markup = serializePreservingVisualAppearance(m_document.selection().selection(), ResolveURLs::YesExcludingLocalFileURLsForPrivacy, SerializeComposedTree::Yes : SerializeComposedTree::No); Ditto.
Created attachment 450832 [details] Patch
Comment on attachment 450832 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450832&action=review > Source/WebCore/editing/Editor.cpp:3313 > + return selectedText(OptionSet { TextIteratorBehavior::EmitsImageAltText } | TextIteratorBehavior::TraversesFlatTree); Should use commas here instead: return selectedText({ TextIteratorBehavior::EmitsImageAltText, TextIteratorBehavior::TraversesFlatTree });
(In reply to Darin Adler from comment #4) > Comment on attachment 450832 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450832&action=review > > > Source/WebCore/editing/Editor.cpp:3313 > > + return selectedText(OptionSet { TextIteratorBehavior::EmitsImageAltText } | TextIteratorBehavior::TraversesFlatTree); > > Should use commas here instead: > > return selectedText({ TextIteratorBehavior::EmitsImageAltText, > TextIteratorBehavior::TraversesFlatTree }); Sure, will fix.
Created attachment 450865 [details] Patch for landing
Committed r289104 (246801@main): <https://commits.webkit.org/246801@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450865 [details].
<rdar://problem/88474922>
Comment on attachment 450865 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=450865&action=review > Source/WebCore/editing/Editor.cpp:3313 > + return selectedText(OptionSet { TextIteratorBehavior::EmitsImageAltText, TextIteratorBehavior::TraversesFlatTree }); Maybe we can omit OptionSet here? I guess not because you would have tried that?
(In reply to Darin Adler from comment #9) > Comment on attachment 450865 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450865&action=review > > > Source/WebCore/editing/Editor.cpp:3313 > > + return selectedText(OptionSet { TextIteratorBehavior::EmitsImageAltText, TextIteratorBehavior::TraversesFlatTree }); > > Maybe we can omit OptionSet here? I guess not because you would have tried > that? No, it didn't work.