RESOLVED FIXED235993
Delete SelectionAcrossShadowBoundariesEnabled 
https://bugs.webkit.org/show_bug.cgi?id=235993
Summary Delete SelectionAcrossShadowBoundariesEnabled
Ryosuke Niwa
Reported 2022-02-01 17:50:55 PST
This runtime flag is always on.
Attachments
Patch (15.02 KB, patch)
2022-02-01 17:54 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch (14.96 KB, patch)
2022-02-03 15:52 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.95 KB, patch)
2022-02-03 21:48 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2022-02-01 17:54:04 PST
Created attachment 450598 [details] Patch
Darin Adler
Comment 2 2022-02-03 03:58:14 PST
Comment on attachment 450598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450598&action=review > Source/WebCore/editing/gtk/EditorGtk.cpp:120 > + pasteboardContent.markup = serializePreservingVisualAppearance(m_document.selection().selection(), ResolveURLs::YesExcludingLocalFileURLsForPrivacy, SerializeComposedTree::Yes : SerializeComposedTree::No); Editing mistake here. Left behind “: SerializedComposedTree::No”. > Source/WebCore/editing/libwpe/EditorLibWPE.cpp:68 > + pasteboardContent.markup = serializePreservingVisualAppearance(m_document.selection().selection(), ResolveURLs::YesExcludingLocalFileURLsForPrivacy, SerializeComposedTree::Yes : SerializeComposedTree::No); Ditto.
Ryosuke Niwa
Comment 3 2022-02-03 15:52:35 PST
Created attachment 450832 [details] Patch
Darin Adler
Comment 4 2022-02-03 16:37:33 PST
Comment on attachment 450832 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450832&action=review > Source/WebCore/editing/Editor.cpp:3313 > + return selectedText(OptionSet { TextIteratorBehavior::EmitsImageAltText } | TextIteratorBehavior::TraversesFlatTree); Should use commas here instead: return selectedText({ TextIteratorBehavior::EmitsImageAltText, TextIteratorBehavior::TraversesFlatTree });
Ryosuke Niwa
Comment 5 2022-02-03 21:47:25 PST
(In reply to Darin Adler from comment #4) > Comment on attachment 450832 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450832&action=review > > > Source/WebCore/editing/Editor.cpp:3313 > > + return selectedText(OptionSet { TextIteratorBehavior::EmitsImageAltText } | TextIteratorBehavior::TraversesFlatTree); > > Should use commas here instead: > > return selectedText({ TextIteratorBehavior::EmitsImageAltText, > TextIteratorBehavior::TraversesFlatTree }); Sure, will fix.
Ryosuke Niwa
Comment 6 2022-02-03 21:48:12 PST
Created attachment 450865 [details] Patch for landing
EWS
Comment 7 2022-02-03 22:38:26 PST
Committed r289104 (246801@main): <https://commits.webkit.org/246801@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450865 [details].
Radar WebKit Bug Importer
Comment 8 2022-02-03 22:39:25 PST
<rdar://problem/88474922>
Darin Adler
Comment 9 2022-02-04 08:15:21 PST
Comment on attachment 450865 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=450865&action=review > Source/WebCore/editing/Editor.cpp:3313 > + return selectedText(OptionSet { TextIteratorBehavior::EmitsImageAltText, TextIteratorBehavior::TraversesFlatTree }); Maybe we can omit OptionSet here? I guess not because you would have tried that?
Ryosuke Niwa
Comment 10 2022-02-04 11:34:55 PST
(In reply to Darin Adler from comment #9) > Comment on attachment 450865 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450865&action=review > > > Source/WebCore/editing/Editor.cpp:3313 > > + return selectedText(OptionSet { TextIteratorBehavior::EmitsImageAltText, TextIteratorBehavior::TraversesFlatTree }); > > Maybe we can omit OptionSet here? I guess not because you would have tried > that? No, it didn't work.
Note You need to log in before you can comment on or make changes to this bug.