Bug 235991 - Adjust some Live Text code to only use VKC-prefixed VisionKit classes if ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS)
Summary: Adjust some Live Text code to only use VKC-prefixed VisionKit classes if ENAB...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on: 235980
Blocks:
  Show dependency tree / graph
 
Reported: 2022-02-01 17:36 PST by Wenson Hsieh
Modified: 2022-02-02 09:54 PST (History)
6 users (show)

See Also:

Attachments
Patch (17.69 KB, patch)
2022-02-01 17:48 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2022-02-01 17:36:39 PST 
.
Comment 1 Wenson Hsieh 2022-02-01 17:48:04 PST 
Created attachment 450597 [details]
Patch
Comment 2 Megan Gardner 2022-02-02 09:41:42 PST 
Comment on attachment 450597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450597&action=review

> Source/WebKit/Platform/cocoa/TextRecognitionUtilities.h:57
> +RetainPtr<CocoaImageAnalyzerRequest> createImageAnalyzerRequest(CGImageRef, VKAnalysisTypes);

Is VKAnalysisTypes not also getting replaced?
Comment 3 Wenson Hsieh 2022-02-02 09:45:02 PST 
Thanks for the review!

(In reply to Megan Gardner from comment #2)
> Comment on attachment 450597 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450597&action=review
> 
> > Source/WebKit/Platform/cocoa/TextRecognitionUtilities.h:57
> > +RetainPtr<CocoaImageAnalyzerRequest> createImageAnalyzerRequest(CGImageRef, VKAnalysisTypes);
> 
> Is VKAnalysisTypes not also getting replaced?

Indeed — `VKAnalysisTypes` are remaining as-is. I'll check in with the relevant folks to see if this is intentional...
Comment 4 EWS 2022-02-02 09:53:49 PST 
Committed r288956 (246685@main): <https://commits.webkit.org/246685@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450597 [details].
Comment 5 Radar WebKit Bug Importer 2022-02-02 09:54:33 PST 
<rdar://problem/88386531>