Bug 235991 – Adjust some Live Text code to only use VKC-prefixed VisionKit classes if ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS)

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

.

[Wenson Hsieh]

Created attachment 450597 [details]
Patch

[Megan Gardner]

Comment on attachment 450597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450597&action=review

> Source/WebKit/Platform/cocoa/TextRecognitionUtilities.h:57
> +RetainPtr<CocoaImageAnalyzerRequest> createImageAnalyzerRequest(CGImageRef, VKAnalysisTypes);

Is VKAnalysisTypes not also getting replaced?

[Wenson Hsieh]

Thanks for the review!

(In reply to Megan Gardner from comment #2)
> Comment on attachment 450597 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450597&action=review
> 
> > Source/WebKit/Platform/cocoa/TextRecognitionUtilities.h:57
> > +RetainPtr<CocoaImageAnalyzerRequest> createImageAnalyzerRequest(CGImageRef, VKAnalysisTypes);
> 
> Is VKAnalysisTypes not also getting replaced?

Indeed — `VKAnalysisTypes` are remaining as-is. I'll check in with the relevant folks to see if this is intentional...

[EWS]

Committed r288956 (246685@main): <https://commits.webkit.org/246685@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450597 [details].

[Radar WebKit Bug Importer]

<rdar://problem/88386531>