Bug 235976 - Catalyst builds of WebKit with system content path put XPCServices and Daemons in the normal location
Summary: Catalyst builds of WebKit with system content path put XPCServices and Daemon...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-01 14:48 PST by Michael Saboff
Modified: 2022-02-01 15:53 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2022-02-01 15:01 PST, Michael Saboff 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2022-02-01 14:48:00 PST 
When building with a system content path the Catalyst versions of WebKit Daemons and XPCServices end up in .../System/Library/Frameworks/WebKit.framework/Versions/A/{Daemons|XPCServices} instead of .../System//iOSSupport/System/Library/Frameworks/WebKit.framework/Versions/A/{Daemons|XPCServices}.
Comment 1 Michael Saboff 2022-02-01 14:48:13 PST 
<rdar://88334496>
Comment 2 Michael Saboff 2022-02-01 15:01:01 PST 
Created attachment 450573 [details]
Patch
Comment 3 Mark Lam 2022-02-01 15:05:14 PST 
Comment on attachment 450573 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450573&action=review

> Source/WebKit/ChangeLog:8
> +        The production of WEBKIT_FRAMEWORKS_DIR_USE_SYSTEM_CONTENT_PATH_YES used the system framekwork path

/framekwork/framework.
Comment 4 Michael Saboff 2022-02-01 15:18:09 PST 
(In reply to Mark Lam from comment #3)
> Comment on attachment 450573 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450573&action=review
> 
> > Source/WebKit/ChangeLog:8
> > +        The production of WEBKIT_FRAMEWORKS_DIR_USE_SYSTEM_CONTENT_PATH_YES used the system framekwork path
> 
> /framekwork/framework.

Fixed locally.
Comment 5 Michael Saboff 2022-02-01 15:53:19 PST 
Committed r288917 (246656@trunk): <https://commits.webkit.org/246656@trunk>