Bug 235972 - Add setting to toggle PDF.js viewer
Summary: Add setting to toggle PDF.js viewer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks: 235969
  Show dependency tree / graph
 
Reported: 2022-02-01 13:10 PST by Tim Nguyen (:ntim)
Modified: 2022-02-01 17:19 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.06 KB, patch)
2022-02-01 15:02 PST, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (4.03 KB, patch)
2022-02-01 15:10 PST, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (2.66 KB, patch)
2022-02-01 15:15 PST, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2022-02-01 13:10:04 PST 
^
Comment 1 Radar WebKit Bug Importer 2022-02-01 13:10:16 PST 
<rdar://problem/88344595>
Comment 2 Tim Nguyen (:ntim) 2022-02-01 15:02:24 PST 
Created attachment 450574 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2022-02-01 15:10:16 PST 
Created attachment 450577 [details]
Patch
Comment 4 Tim Horton 2022-02-01 15:12:02 PST 
Comment on attachment 450577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450577&action=review

> Tools/WebKitTestRunner/TestOptions.cpp:111
> +            { "PdfJSViewerEnabled", false },

I think you can get rid of this now that it's not experimental
Comment 5 Chris Dumez 2022-02-01 15:12:13 PST 
Comment on attachment 450577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450577&action=review

> Tools/WebKitTestRunner/TestOptions.cpp:111
> +            { "PdfJSViewerEnabled", false },

Should no longer be needed now that it is no longer experimental.
Comment 6 Tim Nguyen (:ntim) 2022-02-01 15:15:27 PST 
Created attachment 450578 [details]
Patch
Comment 7 EWS 2022-02-01 17:19:20 PST 
Committed r288930 (246661@main): <https://commits.webkit.org/246661@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450578 [details].