Bug 235971 - [EWS] Fix infinate retry on PR with red ToT
Summary: [EWS] Fix infinate retry on PR with red ToT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-01 13:07 PST by Jonathan Bedard
Modified: 2022-02-01 16:21 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-02-01 13:07:17 PST 
If a pull request fails to build in EWS because the base branch doesn't build, we end up in an infinite retry. Because we don't automatically rebase pull requests, we shouldn't retry if the base commit fails to build.
Comment 1 Radar WebKit Bug Importer 2022-02-01 13:07:31 PST 
<rdar://problem/88344438>
Comment 2 Jonathan Bedard 2022-02-01 13:53:14 PST 
Landed 246651@main (r288911)
Comment 3 Aakash Jain 2022-02-01 16:21:56 PST 
Pull Request: https://github.com/WebKit/WebKit/pull/116#pullrequestreview-869839439