Bug 235953 – MediaRecorderPrivate should not need to create IOSurfaces

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

MediaRecorderPrivate should not need to create IOSurfaces

[youenn fablet]

Created attachment 450532 [details]
Patch

[youenn fablet]

Created attachment 450641 [details]
Patch

[Eric Carlson]

Comment on attachment 450641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450641&action=review

> Source/WebKit/ChangeLog:13
>          * WebProcess/cocoa/UserMediaCaptureManager.cpp:
>  
> [phone]  Youenn Fablet  <[e-mail]>

This doesn't look right

> Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp:95
> +        if (!pixelBuffer)
> +            return;

Is it worth logging an error message?

> Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:110
> +        if (!copySharedVideoFrame(remoteSample->imageBuffer()))
> +            return;

Ditto

[youenn fablet]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 450641 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450641&action=review
> 
> > Source/WebKit/ChangeLog:13
> >          * WebProcess/cocoa/UserMediaCaptureManager.cpp:
> >  
> > [phone]  Youenn Fablet  <[e-mail]>
> 
> This doesn't look right

Right, will fix.

> > Source/WebKit/GPUProcess/webrtc/RemoteMediaRecorder.cpp:95
> > +        if (!pixelBuffer)
> > +            return;
> 
> Is it worth logging an error message?
> 
> > Source/WebKit/WebProcess/GPU/webrtc/MediaRecorderPrivate.cpp:110
> > +        if (!copySharedVideoFrame(remoteSample->imageBuffer()))
> > +            return;
> 
> Ditto

It is worth, the issue is that it might log this 30 fps per second which is a lot.
I'll file a bug to add reasonable logging at reader/writer level.

[youenn fablet]

I filed https://bugs.webkit.org/show_bug.cgi?id=236066

[youenn fablet]

Created attachment 450749 [details]
Patch for landing

[EWS]

Committed r289050 (246757@main): <https://commits.webkit.org/246757@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450749 [details].

[Radar WebKit Bug Importer]

<rdar://problem/88432554>