Bug 235952 - RealtimeIncomingVideoSourceCocoa should not need to create IOSurfaces
Summary: RealtimeIncomingVideoSourceCocoa should not need to create IOSurfaces
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 235951
Blocks:
  Show dependency tree / graph
 
Reported: 2022-02-01 08:00 PST by youenn fablet
Modified: 2022-02-03 06:08 PST (History)
11 users (show)

See Also:

Attachments
Patch (7.78 KB, patch)
2022-02-01 08:19 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (7.27 KB, patch)
2022-02-03 01:36 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-02-01 08:00:28 PST 
RealtimeIncomingVideoSourceCocoa should not need to create IOSurfaces
Comment 1 youenn fablet 2022-02-01 08:19:08 PST 
Created attachment 450530 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-02-01 08:39:54 PST 
<rdar://problem/88329641>
Comment 3 youenn fablet 2022-02-02 06:45:17 PST 
Comment on attachment 450530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450530&action=review

> Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:121
>          }

https://bugs.webkit.org/show_bug.cgi?id=236011 is introducing createInMemoryCVPixelBufferPool we should probably use here.
Comment 4 youenn fablet 2022-02-03 01:36:00 PST 
Created attachment 450747 [details]
Patch for landing
Comment 5 EWS 2022-02-03 06:08:55 PST 
Committed r289049 (246756@main): <https://commits.webkit.org/246756@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450747 [details].