Bug 235944 - [Forms] Alias appearance <compat-auto> keywords to 'auto'
Summary: [Forms] Alias appearance <compat-auto> keywords to 'auto'
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zsun
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-01 03:08 PST by zsun
Modified: 2022-02-07 01:24 PST (History)
11 users (show)

See Also:


Attachments
Patch (14.12 KB, patch)
2022-02-02 04:11 PST, zsun
no flags Details | Formatted Diff | Diff
Patch (10.62 KB, patch)
2022-02-02 12:06 PST, zsun
no flags Details | Formatted Diff | Diff
Patch (10.28 KB, patch)
2022-02-03 01:11 PST, zsun
no flags Details | Formatted Diff | Diff
Patch (10.26 KB, patch)
2022-02-04 01:19 PST, zsun
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 zsun 2022-02-02 04:11:09 PST
Created attachment 450632 [details]
Patch
Comment 2 zsun 2022-02-02 12:06:47 PST
Created attachment 450687 [details]
Patch
Comment 3 zsun 2022-02-03 01:11:47 PST
Created attachment 450744 [details]
Patch
Comment 4 Aditya Keerthi 2022-02-03 14:15:42 PST
Comment on attachment 450744 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450744&action=review

> Source/WebCore/rendering/RenderTheme.cpp:90
> +    if (!element)

Nit: The early return here can be moved before the declaration/assignment of `part`.

> Source/WebCore/rendering/RenderTheme.h:469
> +    ControlPart adjustAppearanceWithElementType(RenderStyle&, const Element*) const;

Consider renaming this to `adjustAppearanceForElement`, since it doesn't take an "element type".
Comment 5 zsun 2022-02-04 01:19:40 PST
Created attachment 450880 [details]
Patch
Comment 6 EWS 2022-02-07 01:23:41 PST
Committed r289201 (246887@main): <https://commits.webkit.org/246887@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450880 [details].
Comment 7 Radar WebKit Bug Importer 2022-02-07 01:24:19 PST
<rdar://problem/88561704>