Bug 235942 - [GTK][WPE] Switch to use ATSPI instead of ATK
Summary: [GTK][WPE] Switch to use ATSPI instead of ATK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: ATSPI
  Show dependency tree / graph
 
Reported: 2022-02-01 01:26 PST by Carlos Garcia Campos
Modified: 2022-02-06 19:56 PST (History)
15 users (show)

See Also:

Attachments
Patch (43.45 KB, patch)
2022-02-01 01:28 PST, Carlos Garcia Campos 		aperez: review+
aperez: commit-queue-
Details | Formatted Diff | Diff
Patch (43.86 KB, patch)
2022-02-01 01:34 PST, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2022-02-01 01:26:58 PST 
Use ATSPI by default.
Comment 1 Carlos Garcia Campos 2022-02-01 01:28:51 PST 
Created attachment 450508 [details]
Patch
Comment 2 Carlos Garcia Campos 2022-02-01 01:34:01 PST 
Created attachment 450509 [details]
Patch
Comment 3 Adrian Perez 2022-02-01 03:10:12 PST 
Comment on attachment 450508 [details]
Patch

Patch LGTM, modulo making the style checker happy before landing.

I am glad to see the default being switched to the new implementation \o/
Comment 4 Carlos Garcia Campos 2022-02-01 03:11:38 PST 
(In reply to Adrian Perez from comment #3)
> Comment on attachment 450508 [details]
> Patch
> 
> Patch LGTM, modulo making the style checker happy before landing.
> 
> I am glad to see the default being switched to the new implementation \o/

Already submitted a new patch with the style issue fixed.
Comment 5 Adrian Perez 2022-02-01 03:13:16 PST 
(In reply to Carlos Garcia Campos from comment #4)
> (In reply to Adrian Perez from comment #3)
> > Comment on attachment 450508 [details]
> > Patch
> > 
> > Patch LGTM, modulo making the style checker happy before landing.
> > 
> > I am glad to see the default being switched to the new implementation \o/
> 
> Already submitted a new patch with the style issue fixed.

You sir, are fast! 🚀️
Comment 6 Carlos Garcia Campos 2022-02-01 04:29:11 PST 
Committed r288872 (246624@trunk): <https://commits.webkit.org/246624@trunk>