Bug 235940 – Revert OSAllocator behavior to pre-Structure-Allocator change one

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

Revert OSAllocator behavior to pre-Structure-Allocator change one

[Yusuke Suzuki]

Created attachment 450504 [details]
Patch

[Mark Lam]

Comment on attachment 450504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450504&action=review

r=me

> Source/WTF/ChangeLog:42
> +        We also fix that tryReserveUncommitted is not correctly handling MAP_FAILED. We should not return MAP_FAILED from OSAllocator, instead,

I suggest "fix that tryReserveUncommitted is not correctly handling MAP_FAILED" => "fix a bug in tryReserveUncommitted where it handles MAP_FAILED incorrectly".

> Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp:116
> +void* OSAllocator::tryReserveUncommitted(size_t bytes, Usage usage, bool writable, bool executable, bool jitCageEnabled, bool includesGuardPages)

Why remove the "OSAllocator::" qualifier for Usage?  You kept to for tryReserveAndCommit above.  I see that it is not used for functions below.  Maybe remove it also for tryReserveAndCommit above?

[Yusuke Suzuki]

Comment on attachment 450504 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450504&action=review

>> Source/WTF/ChangeLog:42
>> +        We also fix that tryReserveUncommitted is not correctly handling MAP_FAILED. We should not return MAP_FAILED from OSAllocator, instead,
> 
> I suggest "fix that tryReserveUncommitted is not correctly handling MAP_FAILED" => "fix a bug in tryReserveUncommitted where it handles MAP_FAILED incorrectly".

Changed.

>> Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp:116
>> +void* OSAllocator::tryReserveUncommitted(size_t bytes, Usage usage, bool writable, bool executable, bool jitCageEnabled, bool includesGuardPages)
> 
> Why remove the "OSAllocator::" qualifier for Usage?  You kept to for tryReserveAndCommit above.  I see that it is not used for functions below.  Maybe remove it also for tryReserveAndCommit above?

Because now it is static function of OSAllocator::. So, we don't need OSAllocator:: prefix to Usage.
Removed that of tryReserveAndCommit too.

[Yusuke Suzuki]

Committed r288870 (246622@trunk): <https://commits.webkit.org/246622@trunk>

[Radar WebKit Bug Importer]

<rdar://problem/88318960>