Bug 235939 - [GPU Process] Remove DisplayList::Replayer::Delegate and DisplayList::RecorderImpl::Delegate
Summary: [GPU Process] Remove DisplayList::Replayer::Delegate and DisplayList::Recorde...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 236508
  Show dependency tree / graph
 
Reported: 2022-01-31 21:42 PST by Said Abou-Hallawa
Modified: 2022-02-11 13:26 PST (History)
7 users (show)

See Also:

Attachments
Patch (28.51 KB, patch)
2022-01-31 21:46 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (28.38 KB, patch)
2022-01-31 23:10 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (31.83 KB, patch)
2022-01-31 23:47 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (31.92 KB, patch)
2022-02-01 01:24 PST, Said Abou-Hallawa 		wenson_hsieh: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (31.91 KB, patch)
2022-02-02 11:42 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2022-01-31 21:42:53 PST 
These classes are abstract classes and they are not overridden by any client right now. These unused classes should be removed after the display list stream connection refactoring.
Comment 1 Said Abou-Hallawa 2022-01-31 21:46:27 PST 
Created attachment 450498 [details]
Patch
Comment 2 Said Abou-Hallawa 2022-01-31 23:10:29 PST 
Created attachment 450501 [details]
Patch
Comment 3 Said Abou-Hallawa 2022-01-31 23:47:06 PST 
Created attachment 450503 [details]
Patch
Comment 4 Said Abou-Hallawa 2022-02-01 01:24:23 PST 
Created attachment 450507 [details]
Patch
Comment 5 Wenson Hsieh 2022-02-01 10:55:02 PST 
Comment on attachment 450507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450507&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListReplayer.cpp:94
> +        return *imageIdentifier;

Nit - let's keep these return types on line 94 and 97 consistent (maybe by getting the value inside the optional in both cases).
Comment 6 Said Abou-Hallawa 2022-02-02 11:42:36 PST 
Created attachment 450681 [details]
Patch
Comment 7 EWS 2022-02-02 13:09:55 PST 
Committed r288991 (246710@main): <https://commits.webkit.org/246710@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450681 [details].
Comment 8 Radar WebKit Bug Importer 2022-02-02 13:10:18 PST 
<rdar://problem/88397449>