Bug 235938 - Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to fontMetricsOfPrimaryFont()
Summary: Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to fontMetri...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-31 20:33 PST by Myles C. Maxfield
Modified: 2022-02-01 21:13 PST (History)
35 users (show)

See Also:

Attachments
Patch (99.88 KB, patch)
2022-01-31 20:34 PST, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (100.91 KB, patch)
2022-01-31 20:49 PST, Myles C. Maxfield 		zalan: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (103.02 KB, patch)
2022-01-31 20:59 PST, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (105.12 KB, patch)
2022-01-31 21:03 PST, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (105.97 KB, patch)
2022-01-31 21:29 PST, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (107.64 KB, patch)
2022-01-31 21:56 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-01-31 20:33:22 PST 
Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to fontMetricsOfPrimaryFont()
Comment 1 Myles C. Maxfield 2022-01-31 20:34:45 PST 
Created attachment 450493 [details]
Patch
Comment 2 Myles C. Maxfield 2022-01-31 20:49:05 PST 
Created attachment 450494 [details]
Patch
Comment 3 Myles C. Maxfield 2022-01-31 20:59:11 PST 
Created attachment 450495 [details]
Patch for committing
Comment 4 Myles C. Maxfield 2022-01-31 21:03:16 PST 
Created attachment 450496 [details]
Patch for committing
Comment 5 Myles C. Maxfield 2022-01-31 21:29:43 PST 
Created attachment 450497 [details]
Patch for committing
Comment 6 Myles C. Maxfield 2022-01-31 21:56:45 PST 
Created attachment 450499 [details]
Patch for committing
Comment 7 EWS 2022-01-31 23:45:16 PST 
Committed r288868 (246620@main): <https://commits.webkit.org/246620@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450499 [details].
Comment 8 Radar WebKit Bug Importer 2022-01-31 23:46:17 PST 
<rdar://problem/88314722>
Comment 9 Darin Adler 2022-02-01 08:54:29 PST 
(In reply to Myles C. Maxfield from comment #0)
> Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to
> fontMetricsOfPrimaryFont()

But do we need the word "font" twice in this name.
Comment 10 Myles C. Maxfield 2022-02-01 09:17:45 PST 
(In reply to Darin Adler from comment #9)
> (In reply to Myles C. Maxfield from comment #0)
> > Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to
> > fontMetricsOfPrimaryFont()
> 
> But do we need the word "font" twice in this name.

I thought that would be better than “primaryFontsMetrics” because the missing apostrophe makes it unclear whether “font” is plural or possessive.

Also making it a wordy name has the extra benefit that people might be less likely to call it in the future 😅
Comment 11 Myles C. Maxfield 2022-02-01 09:20:16 PST 
(And also better than primaryFontMetrics because it’s unclear whether the “primary” applies to the font or to the metrics.)

Maybe “metricsOfPrimaryFont()” is better?
Comment 12 Darin Adler 2022-02-01 09:33:18 PST 
(In reply to Myles C. Maxfield from comment #11)
> Maybe “metricsOfPrimaryFont()” is better?

Yes, if I caught you in time I would have suggested that. Since fontMetricsOfPrimaryFont is a long unique name we can do it mechanically. do-webcore-rename can do it for us.
Comment 13 Myles C. Maxfield 2022-02-01 21:13:01 PST 
Committed r288942 (246672@trunk): <https://commits.webkit.org/246672@trunk>