Bug 23593 - RenderThemeChromium[Win,Mac].cpp don't compile after renderbox changes
Summary: RenderThemeChromium[Win,Mac].cpp don't compile after renderbox changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-28 11:29 PST by Tony Chang
Modified: 2009-01-28 12:37 PST (History)
0 users

See Also:


Attachments
[1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin. (3.82 KB, patch)
2009-01-28 11:38 PST, Tony Chang
hyatt: review+
Details | Formatted Diff | Diff
[1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin. (3.91 KB, patch)
2009-01-28 11:51 PST, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2009-01-28 11:29:00 PST
Patch coming...
Comment 1 Tony Chang 2009-01-28 11:38:43 PST
Created attachment 27113 [details]
[1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin.

This is a follow up for hyatt's RenderBox changes.
---
 WebCore/ChangeLog                            |   12 ++++++++++++
 WebCore/rendering/RenderThemeChromiumMac.mm  |    6 ++++--
 WebCore/rendering/RenderThemeChromiumWin.cpp |   18 ++++++++++--------
 3 files changed, 26 insertions(+), 10 deletions(-)
Comment 2 Dave Hyatt 2009-01-28 11:43:07 PST
Comment on attachment 27113 [details]
[1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin.

You should add isBox() checks and bail with early returns so you don't do a bad cast by accident.  Fix that and r=me.
Comment 3 Tony Chang 2009-01-28 11:51:41 PST
Created attachment 27114 [details]
[1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin.

This is a follow up for hyatt's RenderBox changes.
---
 WebCore/ChangeLog                            |   12 ++++++++++++
 WebCore/rendering/RenderThemeChromiumMac.mm  |    9 +++++++--
 WebCore/rendering/RenderThemeChromiumWin.cpp |   21 +++++++++++++--------
 3 files changed, 32 insertions(+), 10 deletions(-)
Comment 4 Darin Fisher (:fishd, Google) 2009-01-28 12:37:54 PST
http://trac.webkit.org/changeset/40321