Bug 235929 - [iOS] Clean up some issues in the 'com.apple.WebKit.adattributiond.sb' sandbox
Summary: [iOS] Clean up some issues in the 'com.apple.WebKit.adattributiond.sb' sandbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-31 16:58 PST by Brent Fulgham
Modified: 2022-01-31 17:21 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.55 KB, patch)
2022-01-31 17:01 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (3.41 KB, patch)
2022-01-31 17:18 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch for landing (3.54 KB, patch)
2022-01-31 17:20 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2022-01-31 16:58:34 PST
This patch cleans up some issues hit when compiling this new sandbox.
Comment 1 Brent Fulgham 2022-01-31 17:01:11 PST
Created attachment 450477 [details]
Patch
Comment 2 Alex Christensen 2022-01-31 17:11:34 PST
Comment on attachment 450477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450477&action=review

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb:74
> +    (home-subpath "/var/mobile/Library/com.apple.webkit.addattributiond/Version1"))

Let's make this /var/mobile/Library/com.apple.webkit.addattributiond instead of /var/mobile/Library/com.apple.webkit.addattributiond/Version1
Comment 3 Alex Christensen 2022-01-31 17:18:34 PST
Comment on attachment 450477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450477&action=review

>> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb:74
>> +    (home-subpath "/var/mobile/Library/com.apple.webkit.addattributiond/Version1"))
> 
> Let's make this /var/mobile/Library/com.apple.webkit.addattributiond instead of /var/mobile/Library/com.apple.webkit.addattributiond/Version1

I also think we need subpath instead of home-subpath
Comment 4 Alex Christensen 2022-01-31 17:18:56 PST
Created attachment 450479 [details]
Patch
Comment 5 Alex Christensen 2022-01-31 17:19:32 PST
r288860
Comment 6 Brent Fulgham 2022-01-31 17:20:22 PST
Reopening to attach new patch.
Comment 7 Brent Fulgham 2022-01-31 17:20:24 PST
Created attachment 450480 [details]
Patch for landing
Comment 8 Brent Fulgham 2022-01-31 17:21:09 PST
I didn't notice Alex already landed this in r288860.
Comment 9 Brent Fulgham 2022-01-31 17:21:36 PST
<rdar://88081007>