Bug 235907 - null ptr deref in LayoutIntegrationLineLayout LineLayout::adjustForPagination and LineLayout::visualOverflowBoundingBoxRectFor
Summary: null ptr deref in LayoutIntegrationLineLayout LineLayout::adjustForPagination...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gabriel Nava Marino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-31 12:41 PST by Gabriel Nava Marino
Modified: 2022-02-01 10:20 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.68 KB, patch)
2022-01-31 12:48 PST, Gabriel Nava Marino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Nava Marino 2022-01-31 12:41:20 PST
m_inlineContent could become null (such as after calling LineLayout::clearInlineContent(), so we add these two checks to protect against an nullptr deref.

<rdar://problem/88265059>
Comment 1 Gabriel Nava Marino 2022-01-31 12:48:16 PST
Created attachment 450432 [details]
Patch
Comment 2 Gabriel Nava Marino 2022-02-01 09:40:58 PST
Comment on attachment 450432 [details]
Patch

The layout test failures on win are appearing in the WebKit Results Database history in past revisions are unrelated to this patch.
Comment 3 EWS 2022-02-01 10:20:12 PST
Committed r288891 (246638@main): <https://commits.webkit.org/246638@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450432 [details].