Bug 235901 - [macOS][WP] Add required syscall
Summary: [macOS][WP] Add required syscall
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-31 11:07 PST by Per Arne Vollan
Modified: 2022-01-31 14:14 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.14 KB, patch)
2022-01-31 11:09 PST, Per Arne Vollan
bfulgham: review+
Details | Formatted Diff | Diff
Patch (1.19 KB, patch)
2022-01-31 13:11 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2022-01-31 11:07:51 PST
Add required syscall in the WebContent process on macOS.
Comment 1 Per Arne Vollan 2022-01-31 11:08:13 PST
<rdar://88241768>
Comment 2 Per Arne Vollan 2022-01-31 11:09:25 PST
Created attachment 450420 [details]
Patch
Comment 3 Brent Fulgham 2022-01-31 11:12:06 PST
Comment on attachment 450420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450420&action=review

r=me

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1949
> +        SYS_kqueue ;; <rdar://problem/88241768>

Maybe add a comment to remove this again after <rdar://56634240> is resolved?
Comment 4 Per Arne Vollan 2022-01-31 11:55:35 PST
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 450420 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450420&action=review
> 
> r=me
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1949
> > +        SYS_kqueue ;; <rdar://problem/88241768>
> 
> Maybe add a comment to remove this again after <rdar://56634240> is resolved?

That is a good point. I will updated the patch.

Thanks for reviewing!
Comment 5 Per Arne Vollan 2022-01-31 13:11:03 PST
Created attachment 450440 [details]
Patch
Comment 6 EWS 2022-01-31 14:14:21 PST
Committed r288844 (246605@main): <https://commits.webkit.org/246605@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450440 [details].