Bug 235892 - [WP] Remove PostScript conversion code
Summary: [WP] Remove PostScript conversion code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on: 3527
Blocks:
  Show dependency tree / graph
 
Reported: 2022-01-31 08:05 PST by Per Arne Vollan
Modified: 2022-02-07 13:42 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.69 KB, patch)
2022-01-31 08:07 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (6.85 KB, patch)
2022-01-31 15:59 PST, Per Arne Vollan 		thorton: review+
Details | Formatted Diff | Diff
Patch (6.90 KB, patch)
2022-02-01 11:05 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2022-01-31 08:05:02 PST 
The WebContent process no longer has access to the PostScript conversion service, so there is no need to keep this code.
Comment 1 Per Arne Vollan 2022-01-31 08:05:28 PST 
<rdar://88172449>
Comment 2 Per Arne Vollan 2022-01-31 08:07:16 PST 
Created attachment 450411 [details]
Patch
Comment 3 Brent Fulgham 2022-01-31 09:53:55 PST 
Comment on attachment 450411 [details]
Patch

r=me
Comment 4 Per Arne Vollan 2022-01-31 11:02:57 PST 
Comment on attachment 450411 [details]
Patch

Thanks for reviewing!
Comment 5 EWS 2022-01-31 11:37:41 PST 
Committed r288825 (246595@main): <https://commits.webkit.org/246595@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450411 [details].
Comment 6 Per Arne Vollan 2022-01-31 15:59:28 PST 
Reopening to attach new patch.
Comment 7 Per Arne Vollan 2022-01-31 15:59:29 PST 
Created attachment 450472 [details]
Patch
Comment 8 Tim Horton 2022-02-01 10:06:44 PST 
Comment on attachment 450472 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450472&action=review

> Source/WebCore/loader/cache/CachedImage.cpp:530
>      if (!isPostScriptResource())

I expect there’s a slight bit more simplification we can do here
Comment 9 Per Arne Vollan 2022-02-01 11:05:49 PST 
Created attachment 450550 [details]
Patch
Comment 10 Per Arne Vollan 2022-02-01 11:06:40 PST 
(In reply to Tim Horton from comment #8)
> Comment on attachment 450472 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450472&action=review
> 
> > Source/WebCore/loader/cache/CachedImage.cpp:530
> >      if (!isPostScriptResource())
> 
> I expect there’s a slight bit more simplification we can do here

Ah, good catch! I updated the patch.

Thanks for reviewing!
Comment 11 EWS 2022-02-01 16:09:32 PST 
Committed r288922 (246657@main): <https://commits.webkit.org/246657@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450550 [details].
Comment 12 David Kilzer (:ddkilzer) 2022-02-07 13:42:40 PST 
(In reply to EWS from comment #11)
> Committed r288922 (246657@main): <https://commits.webkit.org/246657@main>
> 
> All reviewed patches have been landed. Closing bug and clearing flags on
> attachment 450550 [details].

Per Arne just removed my very first patch for WebKit for Bug 3527 that landed in r12679!

Bug 3527: Allow Safari to open postscript files in browser windows as well
<https://bugs.webkit.org/show_bug.cgi?id=3527>
<https://commits.webkit.org/r12679>