See the patch.
Created attachment 450396 [details] Patch
Created attachment 450397 [details] Screenshot
Note the button and entry style doesn't really match libadwaita, it's just using new colors and borders. The actual style looks similar to the progress bar, but I'm hesitant to use it here since it may not be well visible depending on the surroundings.
Created attachment 450400 [details] Patch
Comment on attachment 450400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450400&action=review > Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp:269 > + /*if (scrollbar.hoveredPart() == NoPart && usesOverlayScrollbars()) > graphicsContext.setFillColor(overlayThumbColor); > - else if (scrollbar.pressedPart() == ThumbPart) > - graphicsContext.setFillColor(static_cast<ThemeAdwaita&>(Theme::singleton()).activeSelectionBackgroundColor()); > + else*/ if (scrollbar.pressedPart() == ThumbPart) What's this commented code?
My bad, forgot to remove that.
Created attachment 450401 [details] Patch
I expect this will need test updates, waiting for EWS to finish to check as it will take forever to run all tests locally.
*** Bug 236119 has been marked as a duplicate of this bug. ***
Created attachment 451085 [details] Patch
Comment on attachment 451085 [details] Patch Nice, thanks for all the pixel-pushing! 🎨️
Hm, not sure what's happening with EWS. Maybe sometihng expired and I need to reupload the patch?
(In reply to Alexander Mikhaylenko from comment #12) > Hm, not sure what's happening with EWS. Maybe sometihng expired and I need > to reupload the patch? The package with the built WebKit is no longer available. You can re-upload the patch after setting the reviewer and let the EWS build it again =)
Created attachment 455687 [details] Patch
Created attachment 455743 [details] The linked test, an image without this patch but with --new-baseline Some tests have extra changes like slight dimension differences - e.g. https://ews-build.s3-us-west-2.amazonaws.com/GTK-WK2-Tests-EWS/455687-12354/retries/tables/mozilla/bugs/bug7342-diffs.html However, it looks like those differences are preexisting and the test only didn't fail because the changes were too small - and with the different button color it's enough to push it over the line. See screenshot for an example. So I'm just blindly updating those tests then, I was trying to figure out what could cause this change...
Created attachment 455748 [details] Patch
Fixed some tests, left out the clearly preexisting ones. Let's see what EWS says...
Created attachment 455759 [details] Patch
Created attachment 455771 [details] Patch
Committed r291901 (248894@main): <https://commits.webkit.org/248894@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455771 [details].