Bug 235882 - ServiceWorkerNavigationPreloader should only be used once
Summary: ServiceWorkerNavigationPreloader should only be used once
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
Keywords: InRadar
Depends on:
Reported: 2022-01-31 03:04 PST by youenn fablet
Modified: 2022-02-02 05:03 PST (History)
3 users (show)

See Also:

Patch (9.40 KB, patch)
2022-01-31 03:13 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (9.32 KB, patch)
2022-02-01 23:33 PST, youenn fablet
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-01-31 03:04:49 PST
Comment 1 youenn fablet 2022-01-31 03:13:33 PST
Created attachment 450394 [details]
Comment 2 Chris Dumez 2022-01-31 11:41:50 PST
Comment on attachment 450394 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=450394&action=review

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:398
> +        RELEASE_LOG_ERROR(ServiceWorker, "ServiceWorkerFetchTask::loadBodyFromPreloader preloader is null");

Could you please add a SWFETCH_RELEASE_LOG_ERROR() for consistency with SWFETCH_RELEASE_LOG()?
Comment 3 youenn fablet 2022-02-01 23:33:34 PST
Created attachment 450619 [details]
Patch for landing
Comment 4 EWS 2022-02-02 02:16:18 PST
Committed r288949 (246678@main): <https://commits.webkit.org/246678@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450619 [details].