WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
235882
ServiceWorkerNavigationPreloader should only be used once
https://bugs.webkit.org/show_bug.cgi?id=235882
Summary
ServiceWorkerNavigationPreloader should only be used once
youenn fablet
Reported
2022-01-31 03:04:49 PST
<
rdar://88226432
>
Attachments
Patch
(9.40 KB, patch)
2022-01-31 03:13 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch for landing
(9.32 KB, patch)
2022-02-01 23:33 PST
,
youenn fablet
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2022-01-31 03:13:33 PST
Created
attachment 450394
[details]
Patch
Chris Dumez
Comment 2
2022-01-31 11:41:50 PST
Comment on
attachment 450394
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=450394&action=review
> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:398 > + RELEASE_LOG_ERROR(ServiceWorker, "ServiceWorkerFetchTask::loadBodyFromPreloader preloader is null");
Could you please add a SWFETCH_RELEASE_LOG_ERROR() for consistency with SWFETCH_RELEASE_LOG()?
youenn fablet
Comment 3
2022-02-01 23:33:34 PST
Created
attachment 450619
[details]
Patch for landing
EWS
Comment 4
2022-02-02 02:16:18 PST
Committed
r288949
(
246678@main
): <
https://commits.webkit.org/246678@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 450619
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug