RESOLVED FIXED Bug 235876
Delete runtime flag for subresource integrity 
https://bugs.webkit.org/show_bug.cgi?id=235876
Summary Delete runtime flag for subresource integrity
Ryosuke Niwa
Reported 2022-01-30 20:22:30 PST
It's always enabled.
Attachments
Patch (9.63 KB, patch)
2022-01-30 20:39 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch (9.60 KB, patch)
2022-01-30 21:49 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2022-01-30 20:39:19 PST
Created attachment 450375 [details] Patch
Ryosuke Niwa
Comment 2 2022-01-30 21:49:40 PST
Created attachment 450377 [details] Patch
Darin Adler
Comment 3 2022-01-30 21:54:45 PST
Comment on attachment 450375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450375&action=review > Source/WebCore/dom/ScriptElement.cpp:293 > + m_element.attributeWithoutSynchronization(HTMLNames::integrityAttr).string(), Might want to check and see if we should change this argument to const AtomString& since it’s an attribute value. Not sure why it uses String, but it might have to do with the conditional, although nullAtom would have let use do that before. > Source/WebCore/dom/ScriptElement.cpp:350 > + m_element.attributeWithoutSynchronization(HTMLNames::integrityAttr).string(), Ditto.
Ryosuke Niwa
Comment 4 2022-01-30 22:15:08 PST
(In reply to Darin Adler from comment #3) > Comment on attachment 450375 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450375&action=review > > > Source/WebCore/dom/ScriptElement.cpp:293 > > + m_element.attributeWithoutSynchronization(HTMLNames::integrityAttr).string(), > > Might want to check and see if we should change this argument to const > AtomString& since it’s an attribute value. Not sure why it uses String, but > it might have to do with the conditional, although nullAtom would have let > use do that before. > > > Source/WebCore/dom/ScriptElement.cpp:350 > > + m_element.attributeWithoutSynchronization(HTMLNames::integrityAttr).string(), > > Ditto. That's a good point. Probably want to tackle that in a separate patch though.
Ryosuke Niwa
Comment 5 2022-01-31 13:37:18 PST
Comment on attachment 450377 [details] Patch Clearing flags on attachment: 450377 Committed r288840 (246604@trunk): <https://commits.webkit.org/246604@trunk>
Ryosuke Niwa
Comment 6 2022-01-31 13:37:22 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2022-01-31 13:38:20 PST
<rdar://problem/88291720>
Ryosuke Niwa
Comment 8 2022-01-31 13:55:45 PST
(In reply to Ryosuke Niwa from comment #4) > (In reply to Darin Adler from comment #3) > > Comment on attachment 450375 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=450375&action=review > > > > > Source/WebCore/dom/ScriptElement.cpp:293 > > > + m_element.attributeWithoutSynchronization(HTMLNames::integrityAttr).string(), > > > > Might want to check and see if we should change this argument to const > > AtomString& since it’s an attribute value. Not sure why it uses String, but > > it might have to do with the conditional, although nullAtom would have let > > use do that before. > > > > > Source/WebCore/dom/ScriptElement.cpp:350 > > > + m_element.attributeWithoutSynchronization(HTMLNames::integrityAttr).string(), > > > > Ditto. > > That's a good point. Probably want to tackle that in a separate patch though. Doing this followup in https://bugs.webkit.org/show_bug.cgi?id=235919.
Note You need to log in before you can comment on or make changes to this bug.