Bug 235864 - Delete runtime preference for enabling input events
Summary: Delete runtime preference for enabling input events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-29 13:33 PST by Ryosuke Niwa
Modified: 2022-01-30 15:26 PST (History)
8 users (show)

See Also:


Attachments
Patch (5.45 KB, patch)
2022-01-29 13:35 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (5.42 KB, patch)
2022-01-29 14:07 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (27.34 KB, patch)
2022-01-29 22:24 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (27.34 KB, patch)
2022-01-30 14:37 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2022-01-29 13:33:45 PST
Delete this preference since input events are always enabled.
Comment 1 Ryosuke Niwa 2022-01-29 13:35:03 PST
Created attachment 450335 [details]
Patch
Comment 2 Wenson Hsieh 2022-01-29 13:52:22 PST
Comment on attachment 450335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450335&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests (OOPS!).
> +

Let's remove this before landing.
Comment 3 Ryosuke Niwa 2022-01-29 13:58:55 PST
(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 450335 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450335&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        No new tests (OOPS!).
> > +
> 
> Let's remove this before landing.

Yup.
Comment 4 Ryosuke Niwa 2022-01-29 14:07:01 PST
Created attachment 450337 [details]
Patch for landing
Comment 5 Ryosuke Niwa 2022-01-29 14:07:27 PST
Comment on attachment 450337 [details]
Patch for landing

Wait for EWS.
Comment 6 Ryosuke Niwa 2022-01-29 15:26:33 PST
Oh oops, I forgot to update the tests!
Comment 7 Ryosuke Niwa 2022-01-29 22:24:09 PST
Created attachment 450353 [details]
Patch for landing
Comment 8 Ryosuke Niwa 2022-01-29 22:24:30 PST
Comment on attachment 450353 [details]
Patch for landing

Wait for EWS.
Comment 9 EWS 2022-01-30 13:39:11 PST
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 10 Ryosuke Niwa 2022-01-30 14:37:22 PST
Created attachment 450370 [details]
Patch for landing
Comment 11 EWS 2022-01-30 15:25:47 PST
Committed r288803 (246579@main): <https://commits.webkit.org/246579@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450370 [details].
Comment 12 Radar WebKit Bug Importer 2022-01-30 15:26:27 PST
<rdar://problem/88246987>