Bug 235860 - [ews] Cleanup code by removing patchFailedToBuild and patchFailedTests properties
Summary: [ews] Cleanup code by removing patchFailedToBuild and patchFailedTests proper...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-29 10:08 PST by Aakash Jain
Modified: 2022-01-31 05:31 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-01-29 10:08:14 PST
Cleanup code by removing patchFailedToBuild and patchFailedTests properties. Those were added in very early days of this instance bringup, when corresponding steps (e.g.: UnApplyPatchIfRequired) were listed statically in factories.py. Later on we started invoking steps dynamically using addStepsAfterCurrentStep and UnApplyPatchIfRequired is no longer called in factories.py. We can just remove all this patchFailedToBuild and patchFailedTests properties logic.
Comment 1 Aakash Jain 2022-01-31 05:30:10 PST
Pull Request: https://github.com/WebKit/WebKit/pull/111
Comment 2 Aakash Jain 2022-01-31 05:30:30 PST
Landed https://commits.webkit.org/246587@main (c249047)!
Comment 3 Radar WebKit Bug Importer 2022-01-31 05:31:16 PST
<rdar://problem/88264910>