WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
235860
[ews] Cleanup code by removing patchFailedToBuild and patchFailedTests properties
https://bugs.webkit.org/show_bug.cgi?id=235860
Summary
[ews] Cleanup code by removing patchFailedToBuild and patchFailedTests proper...
Aakash Jain
Reported
2022-01-29 10:08:14 PST
Cleanup code by removing patchFailedToBuild and patchFailedTests properties. Those were added in very early days of this instance bringup, when corresponding steps (e.g.: UnApplyPatchIfRequired) were listed statically in factories.py. Later on we started invoking steps dynamically using addStepsAfterCurrentStep and UnApplyPatchIfRequired is no longer called in factories.py. We can just remove all this patchFailedToBuild and patchFailedTests properties logic.
Attachments
Add attachment
proposed patch, testcase, etc.
Aakash Jain
Comment 1
2022-01-31 05:30:10 PST
Pull Request:
https://github.com/WebKit/WebKit/pull/111
Aakash Jain
Comment 2
2022-01-31 05:30:30 PST
Landed
https://commits.webkit.org/246587@main
(c249047)!
Radar WebKit Bug Importer
Comment 3
2022-01-31 05:31:16 PST
<
rdar://problem/88264910
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug