Bug 235844 – Collapsed ranges return zero rects in DocumentContext

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Collapsed ranges return zero rects in DocumentContext

[Megan Gardner]

Created attachment 450291 [details]
Patch

[Tim Horton]

Comment on attachment 450291 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450291&action=review

> Source/WebKit/ChangeLog:12
> +        This results in an understandable zero rect for the absolute bounding rects for that character,
> +        which is not really representative of what the bounding rect is. For these situations, we should

Some reference back to the change you made that broke this would be good. ("Before revision X, we did A; afterwards, we did B, but that's a problem because C" instead of this form that only captures C). You and I know the context right now, but it's going to be quickly lost if not recorded here.

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:4576
> +                    absoluteBoundingBox = VisiblePosition(makeDeprecatedLegacyPosition(iterator.range().start)).absoluteCaretBounds();

is it really right to be adding new `makeDeprecatedLegacyPosition`?

[Megan Gardner]

Created attachment 450461 [details]
Patch for landing

[EWS]

Committed r288849 (246610@main): <https://commits.webkit.org/246610@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450461 [details].

[Radar WebKit Bug Importer]

<rdar://problem/88297028>