Bug 23584 - Update application cache code for the latest round of spec changes
Summary: Update application cache code for the latest round of spec changes
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2009-01-28 05:02 PST by Alexey Proskuryakov
Modified: 2009-01-29 00:27 PST (History)
0 users

See Also:

proposed patch (67.92 KB, patch)
2009-01-28 05:30 PST, Alexey Proskuryakov
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2009-01-28 05:02:24 PST
The changes mostly affect the update process - events are sent at different time, and caches are associated with documents differently.
Comment 1 Alexey Proskuryakov 2009-01-28 05:30:20 PST
Created attachment 27102 [details]
proposed patch
Comment 2 Anders Carlsson 2009-01-28 10:49:28 PST
Comment on attachment 27102 [details]
proposed patch

> +    it = m_pendingMasterResourceLoaders.find(loader);
> +    if (it != m_pendingMasterResourceLoaders.end())
> +        m_pendingMasterResourceLoaders.remove(it);

This could just be m_pendingMasterResourceLoaders.remove(loader);

Looks great otherwise! r=me
Comment 3 Alexey Proskuryakov 2009-01-29 00:27:19 PST
Committed revision 40354.