Bug 23583 – Populate role attribute for Documents

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Sankar Aditya Tanguturi]

When a page is loaded in safari and inspect32 tool is invoked, Accessibility role attribute for document is not properly populated. We need to add a new role i.e documentRole and need to set that role to all document objects.


~ Thanks
Sankar.

[Sankar Aditya Tanguturi]

Created attachment 27095 [details]
Patch to populate role attribute for document elements.

This is a very small patch. This patch just contains the changes to add a new accessibility role i.e. document for document objects and populate it correctly when focused.

[Sankar Aditya Tanguturi]

Created attachment 27096 [details]
Patch to populate role attribute for document elements.

This patch just creates a new accessibility role i.e. documentRole for document objects and populate that role appropriately when focused.

[chris fleizach]

is the document role in windows equivalent to a web area role in Mac?

[Jonas Klink]

Yes, this is also equivalent to ATK's role ATK_ROLE_DOCUMENT_FRAME.

[chris fleizach]

are you sure you need to add a DocumentRole then to the list of roles, since apparently DocumentRole is the same thing as WebAreaRole

[Jonas Klink]

As long as MSAA will return the correct role on Windows (ROLE_SYSTEM_DOCUMENT), either way works for me.

[Sankar Aditya Tanguturi]

This patch returns the appropriate MSAA role i.e. ROLE_SYSTEM_DOCUMENT on windows. I don't find anywhere in the code that returns this role for windows.

~ Thanks

[Mark Rowe (bdash)]

Comment on attachment 27096 [details]
Patch to populate role attribute for document elements.

Based on my reading of the code Chris is right and WebAreaRole already serves this purpose.  I think MSAARole simply needs updated to map WebAreaRole to ROLE_SYSTEM_DOCUMENT on Windows.

[Sankar Aditya Tanguturi]

Created attachment 27235 [details]
Patch to populate role attribute for document elements.

As mentioned in review comments, I have update the patch.

1. Just added changes to populate role attribute for documents objects correctly.
2. Added a new test case. This fix is specific for windows accessibility. So, moved the test case to LayoutTests/platform/win/accessiblity directory.

~ Thanks.

[chris fleizach]

looks ok to me

[Eric Seidel (no email)]

I cleaned up the ChangeLogs some.  I also removed some extra spaces and HTML from the layout test.  I don't understand why the layout test needs to use an onload handler.  I woudl expect it to work inline.  But since I don't have a windows box to test on, I'm just going to leave it using the onload.

The test would really be better as a JS-style test (like those in fast/js) but it's fine for now. :)

I also made     virtual long role() const;
have "virtual" since we try to be explicit about what methods are virtual and what are not, even though the keyword is not strictly required for subclass implementations.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/platform/win/accessibility/document-role-expected.txt
	A	LayoutTests/platform/win/accessibility/document-role.html
	M	WebKit/win/AccessibleDocument.cpp
	M	WebKit/win/AccessibleDocument.h
	M	WebKit/win/ChangeLog
Committed r43018


Thank you for the patch Sankar.