RESOLVED FIXED 235829
[ews] Implement Login with GitHub on EWS 
https://bugs.webkit.org/show_bug.cgi?id=235829
Summary [ews] Implement Login with GitHub on EWS
Aakash Jain
Reported 2022-01-28 10:16:17 PST
Currently EWS doesn't allow login to different users. There is only one account for admins. There are few features which could be benefit for authentication. Since we are anyways going to start using GitHub, we should implement 'Login with GitHub' on EWS. buildbot have some support for Github authentication. https://buildbot.buildbot.net also has 'Login with GitHub' button (on top-right). Reference: https://docs.buildbot.net/latest/developer/auth.html?highlight=authentication#third-party-authentication
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-01-28 10:16:39 PST
<rdar://problem/88192177>
Aakash Jain
Comment 2 2023-01-25 16:00:52 PST
Reference for authorization in buildbot: https://docs.buildbot.net/current/manual/configuration/www.html#authorization-rules
Aakash Jain
Comment 3 2023-01-26 14:12:24 PST
Note that this would allow most of our users to click the 'Retry' button on buildbot builds enabling them to retry failed (or any) build.
Aakash Jain
Comment 4 2023-02-17 03:51:27 PST
Pull request: https://github.com/WebKit/WebKit/pull/10266
Aakash Jain
Comment 5 2023-02-17 04:06:34 PST
*** Bug 244055 has been marked as a duplicate of this bug. ***
EWS
Comment 6 2023-02-20 04:18:53 PST
Committed 260531@main (a2a8bd0fd59f): <https://commits.webkit.org/260531@main> Reviewed commits have been landed. Closing PR #10266 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.