Bug 235823 - (REGRESSION)[IFC][RTL] wpt/css/css-text/white-space/trailing-space-and-text-alignment-rtl-003.html
Summary: (REGRESSION)[IFC][RTL] wpt/css/css-text/white-space/trailing-space-and-text-a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-28 08:24 PST by zalan
Modified: 2022-01-30 08:40 PST (History)
5 users (show)

See Also:


Attachments
test reduction (179 bytes, text/html)
2022-01-28 08:31 PST, zalan
no flags Details
Patch (4.34 KB, patch)
2022-01-28 09:37 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (8.34 KB, patch)
2022-01-29 14:49 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (11.77 KB, patch)
2022-01-29 17:51 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (16.04 KB, patch)
2022-01-29 20:00 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (16.04 KB, patch)
2022-01-30 07:24 PST, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-01-28 08:24:58 PST
fails with IFC
Comment 1 Radar WebKit Bug Importer 2022-01-28 08:25:19 PST
<rdar://problem/88186663>
Comment 2 zalan 2022-01-28 08:31:45 PST
Created attachment 450234 [details]
test reduction
Comment 3 zalan 2022-01-28 09:37:53 PST
Created attachment 450242 [details]
Patch
Comment 4 zalan 2022-01-29 14:49:50 PST
Created attachment 450340 [details]
Patch
Comment 5 zalan 2022-01-29 15:30:56 PST
Comment on attachment 450340 [details]
Patch

This may be making a bit too many runs. Let's just detach the trailing run if needed.
Comment 6 zalan 2022-01-29 17:51:37 PST
Created attachment 450343 [details]
Patch
Comment 7 zalan 2022-01-29 20:00:23 PST
Created attachment 450347 [details]
Patch
Comment 8 Antti Koivisto 2022-01-30 07:15:10 PST
Comment on attachment 450347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450347&action=review

> Source/WebCore/ChangeLog:18
> +            <div stye="width: 2ch; direction: rtl">AB C</div>
> +        and
> +            <div stye="direction: rtl">AB </div>

style=
Comment 9 zalan 2022-01-30 07:24:58 PST
Created attachment 450359 [details]
Patch
Comment 10 EWS 2022-01-30 08:12:31 PST
Committed r288801 (246577@main): <https://commits.webkit.org/246577@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450359 [details].