Bug 235745 - Support additional WPEToolingBackend types
Summary: Support additional WPEToolingBackend types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-27 17:04 PST by Don Olmstead
Modified: 2022-01-31 07:16 PST (History)
9 users (show)

See Also:

Attachments
WIP Patch (19.58 KB, patch)
2022-01-27 17:18 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (20.19 KB, patch)
2022-01-28 10:15 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (20.35 KB, patch)
2022-01-28 10:22 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (20.59 KB, patch)
2022-01-28 10:34 PST, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (20.48 KB, patch)
2022-01-28 10:53 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (22.78 KB, patch)
2022-01-28 11:02 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (22.72 KB, patch)
2022-01-28 11:39 PST, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2022-01-27 17:04:43 PST 
Currently its all FDO.
Comment 1 Don Olmstead 2022-01-27 17:18:52 PST Comment hidden (obsolete)
Comment 2 Don Olmstead 2022-01-28 10:15:25 PST Comment hidden (obsolete)
Comment 3 Don Olmstead 2022-01-28 10:22:54 PST Comment hidden (obsolete)
Comment 4 Don Olmstead 2022-01-28 10:34:52 PST Comment hidden (obsolete)
Comment 5 Don Olmstead 2022-01-28 10:53:04 PST Comment hidden (obsolete)
Comment 6 Don Olmstead 2022-01-28 11:02:19 PST Comment hidden (obsolete)
Comment 7 Don Olmstead 2022-01-28 11:39:45 PST 
Created attachment 450262 [details]
Patch
Comment 8 Don Olmstead 2022-01-30 14:17:47 PST 
This patch only touches WPE code so the Mac failures are bogus.
Comment 9 Adrian Perez 2022-01-31 04:33:16 PST 
Comment on attachment 450262 [details]
Patch

The patch looks reasonable to me, as it is mostly moving things around.
I will wait a bit before setting it as r+, to see if Žan can take a quick
look as well :)
Comment 10 Zan Dobersek 2022-01-31 05:22:50 PST 
Looks fine.
Comment 11 EWS 2022-01-31 07:15:38 PST 
Committed r288814 (246590@main): <https://commits.webkit.org/246590@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450262 [details].
Comment 12 Radar WebKit Bug Importer 2022-01-31 07:16:26 PST 
<rdar://problem/88268667>