WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
235741
Web Inspector: Add another Protocol Version (iOS 15.4)
https://bugs.webkit.org/show_bug.cgi?id=235741
Summary
Web Inspector: Add another Protocol Version (iOS 15.4)
Patrick Angle
Reported
2022-01-27 15:14:57 PST
<
rdar://80792134
>
Attachments
Patch v1.0
(343.69 KB, patch)
2022-01-27 15:22 PST
,
Patrick Angle
no flags
Details
Formatted Diff
Diff
Patch v1.1 - Fix a compatibility comment
(344.85 KB, patch)
2022-01-28 08:58 PST
,
Patrick Angle
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Patrick Angle
Comment 1
2022-01-27 15:22:42 PST
Created
attachment 450189
[details]
Patch v1.0
Devin Rousso
Comment 2
2022-01-27 15:37:47 PST
Comment on
attachment 450189
[details]
Patch v1.0 View in context:
https://bugs.webkit.org/attachment.cgi?id=450189&action=review
r=me, awesome!
> Source/WebInspectorUI/UserInterface/Protocol/Legacy/15.4/InspectorBackendCommands.js:37 > +InspectorBackend.registerCommand("Animation.requestEffectTarget", null, [{"name": "animationId", "type": "string"}], ["nodeId"]);
Since this is still `nodeId`, we should update the comment in `WI.Animation.prototype.requestEffectTarget` to say "iOS 15.4" instead.
Patrick Angle
Comment 3
2022-01-28 08:58:41 PST
Created
attachment 450237
[details]
Patch v1.1 - Fix a compatibility comment
EWS
Comment 4
2022-01-28 09:30:50 PST
Committed
r288743
(
246536@main
): <
https://commits.webkit.org/246536@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 450237
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug