add #if ENABLE(PAN_SCROLLING) around EventHandler::setPanScrollCursor

[Feng Qian]

EventHanlder::setPanScrollCursor is a private method of EventHandler class, and it is only used by autoscrollTimerFired when ENABLE(PAN_SCROLLING) is true. Putting #if ENABLE(PAN_SCROLLING) around Event::setPanScrollCursor can save some bytes for platforms that do not support pan scrolling.

[Feng Qian]

Created attachment 27082 [details]
patch v1

[Holger Freyther]

Can't you compile the libWebCore to an archive (.a) file and let the linker sort that out?

[Feng Qian]

On Android platform, libwebcore is compiled as a shared library (used by browser and other apps). In this case, I think a smart linker should be able to strip setPanScrollCursor off since the function is private and not used, but the linker seems not as smart as we want :(

(In reply to comment #2)
> Can't you compile the libWebCore to an archive (.a) file and let the linker
> sort that out?
> 

[Eric Seidel (no email)]

Comment on attachment 27082 [details]
patch v1

The patch looks fine.  The ChangeLog needs your full name.  You should investigate setting the CHANGE_LOG_NAME environment variable.  see prepare-ChangeLog for more info.

[Feng Qian]

Created attachment 27430 [details]
patch with my name

Thanks, Eric

Updated the patch with fixed name in the changeLog.

[Eric Seidel (no email)]

Comment on attachment 27430 [details]
patch with my name

Still looks good. :)

[Brent Fulgham]

Committed in http://trac.webkit.org/changeset/40767