2009-01-27 Adam Langley <email@example.com>
Reviewed by NOBODY (OOPS!).
Make PlatformWidget on chromium an intptr_t
Created attachment 27081 [details]
Comment on attachment 27081 [details]
+#include <wtf/Assertions.h> // for intptr_t
This doesn't make a lot of sense. Please use the correct system header.
The correct system header (stdint.h) doesn't exist on Windows. Assertions.h contains this code:
Which I can duplicate if you wish, but it seemed better to keep the #ifdefs down.
I think that it could go in StdLibExtras.h (which in fact includes Assertions.h now).
Created attachment 27089 [details]
Updated to use StdLibExtras.h
Comment on attachment 27089 [details]
> @@ -1,3 +1,11 @@
> +2009-01-27 Adam Langley <firstname.lastname@example.org>
> + Reviewed by NOBODY (OOPS!).
> + Make PlatformWidget on chromium an intptr_t
This should include a why, not just a what.