Bug 23573 - Make PlatformWidget an intptr_t on Chromium
Summary: Make PlatformWidget an intptr_t on Chromium
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-01-27 12:29 PST by Adam Langley
Modified: 2009-01-28 10:52 PST (History)
2 users (show)

See Also:

Proposed patch (1.21 KB, patch)
2009-01-27 12:30 PST, Adam Langley
sam: review-
Details | Formatted Diff | Diff
proposed patch (1.21 KB, patch)
2009-01-27 15:30 PST, Adam Langley
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Langley 2009-01-27 12:29:49 PST
2009-01-27  Adam Langley  <agl@google.com>

        Reviewed by NOBODY (OOPS!).

        Make PlatformWidget on chromium an intptr_t

        * platform/chromium/PlatformWidget.h:
Comment 1 Adam Langley 2009-01-27 12:30:50 PST
Created attachment 27081 [details]
Proposed patch
Comment 2 Sam Weinig 2009-01-27 14:38:24 PST
Comment on attachment 27081 [details]
Proposed patch

+#include <wtf/Assertions.h>  // for intptr_t

This doesn't make a lot of sense.  Please use the correct system header.
Comment 3 Adam Langley 2009-01-27 14:43:29 PST
The correct system header (stdint.h) doesn't exist on Windows. Assertions.h contains this code:

#include <stddef.h>
#include <inttypes.h>

Which I can duplicate if you wish, but it seemed better to keep the #ifdefs down.
Comment 4 Alexey Proskuryakov 2009-01-27 14:51:46 PST
I think that it could go in StdLibExtras.h (which in fact includes Assertions.h now).
Comment 5 Adam Langley 2009-01-27 15:30:54 PST
Created attachment 27089 [details]
proposed patch
Comment 6 Adam Langley 2009-01-27 15:31:11 PST
Updated to use StdLibExtras.h
Comment 7 Sam Weinig 2009-01-27 17:20:29 PST
Comment on attachment 27089 [details]
proposed patch

> @@ -1,3 +1,11 @@
> +2009-01-27  Adam Langley  <agl@google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Make PlatformWidget on chromium an intptr_t

This should include a why, not just a what.
Comment 8 Darin Fisher (:fishd, Google) 2009-01-28 10:52:32 PST