Bug 235724 - [XCBuild] Add missing task dependencies on generate-unified-source-bundles.rb
Summary: [XCBuild] Add missing task dependencies on generate-unified-source-bundles.rb
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-27 10:47 PST by Elliott Williams
Modified: 2022-01-27 12:52 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.32 KB, patch)
2022-01-27 11:02 PST, Elliott Williams 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-01-27 10:47:47 PST 
[XCBuild] Missing task dependencies on generate-unified-source-bundles.rb
Comment 1 Elliott Williams 2022-01-27 10:49:33 PST 
The targets which generate unified sources all use /usr/local/include/wtf/Scripts/generate-unified-source-bundles.rb, but do not declare it. In workspace builds, WTF may not have been built and this header may not exist yet.
Comment 2 Elliott Williams 2022-01-27 11:02:43 PST 
Created attachment 450159 [details]
Patch
Comment 3 EWS 2022-01-27 12:51:13 PST 
Committed r288696 (246494@main): <https://commits.webkit.org/246494@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450159 [details].
Comment 4 Radar WebKit Bug Importer 2022-01-27 12:52:16 PST 
<rdar://problem/88148866>