Bug 235718 - Add layout test for Bug 235645
Summary: Add layout test for Bug 235645
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://github.com/web-platform-tests...
Keywords: InRadar
Depends on:
Blocks: 220502
  Show dependency tree / graph
 
Reported: 2022-01-27 08:33 PST by Chris Dumez
Modified: 2022-01-27 14:45 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.01 KB, patch)
2022-01-27 08:48 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.46 KB, patch)
2022-01-27 09:38 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-01-27 08:33:45 PST 
Add layout test for Bug 235645. Clearly, our test coverage was insufficient as it didn't catch the issue.
Comment 1 Chris Dumez 2022-01-27 08:48:05 PST 
Created attachment 450142 [details]
Patch
Comment 2 Darin Adler 2022-01-27 08:53:02 PST 
Comment on attachment 450142 [details]
Patch

Maybe WPT should have tests like this one too?
Comment 3 Chris Dumez 2022-01-27 09:38:52 PST 
Created attachment 450147 [details]
Patch
Comment 4 Chris Dumez 2022-01-27 09:39:17 PST 
Ok, now written as a WPT test. Will send a PR.
Comment 5 EWS Watchlist 2022-01-27 09:40:20 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 6 Chris Dumez 2022-01-27 09:44:34 PST 
Upstream PR: https://github.com/web-platform-tests/wpt/pull/32571
Comment 7 EWS 2022-01-27 12:28:15 PST 
Committed r288695 (246493@main): <https://commits.webkit.org/246493@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450147 [details].
Comment 8 Radar WebKit Bug Importer 2022-01-27 12:29:17 PST 
<rdar://problem/88147811>