Bug 235715 – AXLogger::add should not cause tree updates via children()

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

AXLogger::add(TextStream&, const RefPtr<AXCoreObject>&, bool) currently calls the update version of children, causing behavior to potentially be different between builds with logging enabled and logging disabled.

void AXLogger::add(TextStream& stream, const RefPtr<AXCoreObject>& object, bool recursive)
{
    ...truncated...
    if (recursive) {
        for (auto& child : object->children())
            add(stream, child, true);
    }
    ...truncated
}

The logger should only read the current state of the object / tree, never modify it.

[Radar WebKit Bug Importer]

<rdar://problem/88132984>

[Tyler Wilcock]

Created attachment 450137 [details]
Patch

[EWS]

Committed r288676 (246482@main): <https://commits.webkit.org/246482@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450137 [details].