Bug 235701 - [WPE][a11y] Add option to build with ATSPI
Summary: [WPE][a11y] Add option to build with ATSPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-27 02:51 PST by Carlos Garcia Campos
Modified: 2022-01-27 23:06 PST (History)
7 users (show)

See Also:

Attachments
Patch (12.37 KB, patch)
2022-01-27 02:53 PST, Carlos Garcia Campos 		aperez: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2022-01-27 02:51:15 PST 
.
Comment 1 Carlos Garcia Campos 2022-01-27 02:53:19 PST 
Created attachment 450119 [details]
Patch
Comment 2 Adrian Perez 2022-01-27 04:50:41 PST 
Comment on attachment 450119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450119&action=review

> Source/WebCore/PlatformWPE.cmake:127
> +    )

IIRC we have a similar (if not the same) custom command in PlatformGTK.cmake;
it would be nice to factor out this functionality in a CMake function at some
point. Could be a follow up patch later on.

> Source/cmake/OptionsWPE.cmake:90
> +WEBKIT_OPTION_DEFINE(USE_ATSPI "Whether to use the Atspi a11y implementation instead of ATK." PRIVATE OFF)

Typo: Atspi → ATSPI

(All caps because it is an acronym, wasn't it?)
Comment 3 Carlos Garcia Campos 2022-01-27 23:06:07 PST 
Committed r288731 (246524@trunk): <https://commits.webkit.org/246524@trunk>