RESOLVED FIXED Bug 235700
[GTK][a11y] Do not set the children count when serializing objects for the ATSPI cache 
https://bugs.webkit.org/show_bug.cgi?id=235700
Summary [GTK][a11y] Do not set the children count when serializing objects for the AT...
Carlos Garcia Campos
Reported 2022-01-27 01:59:43 PST
It's confusing the cache if things doesn't happen in the expected order. We handle the children by emitting the children-changed signals. When the children count is set in the cache by AddAccessible signal or as a response to GetItems, atspi sets the accessible children vector size to the given value. If children-changed:add is emitted after that, it's considered a new child and the children vector grows. So, we end up with the double of children, but half of them are just null.
Attachments
Patch (14.97 KB, patch)
2022-01-27 02:06 PST, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2022-01-27 02:06:36 PST
Created attachment 450117 [details] Patch
Adrian Perez
Comment 2 2022-01-27 05:26:37 PST
Comment on attachment 450117 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450117&action=review > Source/WebCore/ChangeLog:8 > + It's confusing the cache if things doesn't happen in the expected order. We handle the children by emitting the s/doesn't happen/don't happen/
Carlos Garcia Campos
Comment 3 2022-01-27 23:01:06 PST
Committed r288726 (246519@trunk): <https://commits.webkit.org/246519@trunk>
Note You need to log in before you can comment on or make changes to this bug.