Bug 235698 - [GTK][a11y] Return null reference for root parent reference if queried before being embedded
Summary: [GTK][a11y] Return null reference for root parent reference if queried before...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: ATSPI
  Show dependency tree / graph
 
Reported: 2022-01-27 01:44 PST by Carlos Garcia Campos
Modified: 2022-01-27 22:59 PST (History)
11 users (show)

See Also:

Attachments
Patch (1.35 KB, patch)
2022-01-27 01:48 PST, Carlos Garcia Campos 		aperez: review+
aperez: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2022-01-27 01:44:53 PST 
Once embedded parent-changed will be emitted.
Comment 1 Carlos Garcia Campos 2022-01-27 01:48:05 PST 
Created attachment 450115 [details]
Patch
Comment 2 Adrian Perez 2022-01-27 05:01:22 PST 
Comment on attachment 450115 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450115&action=review

> Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp:198
> +	return AccessibilityAtspi::singleton().nullReference();

There are tabs used for indentation in this line (this is what the style bot
shouted about), please fix it before landing.
Comment 3 Carlos Garcia Campos 2022-01-27 22:59:01 PST 
Committed r288724 (246517@trunk): <https://commits.webkit.org/246517@trunk>