Bug 235697 - <model> should not be draggable on macOS
Summary: <model> should not be draggable on macOS
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
Keywords: InRadar
Depends on: 235725
Blocks: 227621
  Show dependency treegraph
Reported: 2022-01-27 01:07 PST by Antoine Quint
Modified: 2022-01-27 22:54 PST (History)
7 users (show)

See Also:

Patch (7.17 KB, patch)
2022-01-27 01:12 PST, Antoine Quint
dino: review+
Details | Formatted Diff | Diff
Patch for landing (7.16 KB, patch)
2022-01-27 12:59 PST, Antoine Quint
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-01-27 01:07:27 PST
<model> should only be draggable on iOS
Comment 1 Antoine Quint 2022-01-27 01:12:53 PST
Created attachment 450114 [details]
Comment 2 Antoine Quint 2022-01-27 01:13:24 PST
We're turning off <model> dragging for macOS in bug 227621.
Comment 3 Antoine Quint 2022-01-27 01:27:48 PST
Please ignore that last comment, it was a mistake.
Comment 4 Antoine Quint 2022-01-27 03:08:51 PST
Committed r288670 (246476@trunk): <https://commits.webkit.org/246476@trunk>
Comment 5 Radar WebKit Bug Importer 2022-01-27 03:09:17 PST
Comment 6 Aakash Jain 2022-01-27 11:34:21 PST
(In reply to Antoine Quint from comment #4)
> Committed r288670 (246476@trunk): <https://commits.webkit.org/246476@trunk>
This manual commit broke an iOS api test.
See: https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.DragAndDropTests.CanStartDragOnModel

EWS failure: https://ews-build.webkit.org/#/builders/9/builds/63450

This is now slowing down the api-ios ews queue.
Comment 7 WebKit Commit Bot 2022-01-27 12:05:35 PST
Re-opened since this is blocked by bug 235725
Comment 8 Antoine Quint 2022-01-27 12:59:16 PST
Created attachment 450167 [details]
Patch for landing
Comment 9 Antoine Quint 2022-01-27 22:54:11 PST
Committed r288723 (246516@trunk): <https://commits.webkit.org/246516@trunk>