Bug 235680 - const/non-const and inclusive/non-inclusive shared code improvements for RenderDescendantIterator adapters
Summary: const/non-const and inclusive/non-inclusive shared code improvements for Rend...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gabriel Nava Marino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-26 16:21 PST by Gabriel Nava Marino
Modified: 2022-02-02 16:22 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Nava Marino 2022-01-26 16:21:09 PST 
As pointed out in https://bugs.webkit.org/show_bug.cgi?id=234018#c28:

To avoid code duplication, we should find a way to share code between the non-inclusive and inclusive RenderDescendantIteratorAdapters, since the non-inclusive case is just like inclusive case, but just skipping the thing itself.

We should also find a way to support a const reference for descendantsOfType, similarly in a way that avoids duplicating all the code twice, such as by using some const_cast in the implementation.
Comment 1 Radar WebKit Bug Importer 2022-02-02 16:22:15 PST 
<rdar://problem/88407384>