Bug 235630 - [WebGPU] Make sure WGSLUnitTests can call into WGSL
Summary: [WebGPU] Make sure WGSLUnitTests can call into WGSL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-26 00:32 PST by Myles C. Maxfield
Modified: 2022-01-27 01:11 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.50 KB, patch)
2022-01-26 00:33 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (2.51 KB, patch)
2022-01-26 00:34 PST, Myles C. Maxfield 		rmorisset: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-01-26 00:32:31 PST 
[WebGPU] Make sure WGSLUnitTests can call into WGSL
Comment 1 Myles C. Maxfield 2022-01-26 00:33:47 PST 
Created attachment 450000 [details]
Patch
Comment 2 Myles C. Maxfield 2022-01-26 00:34:52 PST 
Created attachment 450001 [details]
Patch
Comment 3 EWS 2022-01-26 13:59:17 PST 
Committed r288643 (246453@main): <https://commits.webkit.org/246453@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450001 [details].
Comment 4 Radar WebKit Bug Importer 2022-01-26 14:00:17 PST 
<rdar://problem/88094267>
Comment 5 Darin Adler 2022-01-26 15:21:43 PST 
Comment on attachment 450001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450001&action=review

> Source/WebGPU/ChangeLog:9
> +        (WGSL::staticCheck): Apparently /usr/local/include/AssertMacros.h #defines "check"

In paste we have worked around such things with "#undef".

See the "#undef new" and "#undef delete" in config.h. And "#undef try" and "#undef catch" in WebCorePrefix.h.

But renaming our function is also OK.
Comment 6 Robin Morisset 2022-01-27 01:11:48 PST 
Comment on attachment 450001 [details]
Patch

r=me