Bug 235614 - globalThis.queueMicrotask() should report thrown exceptions
Summary: globalThis.queueMicrotask() should report thrown exceptions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Minor
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-25 15:27 PST by Alexey Shvayka
Modified: 2022-01-26 19:10 PST (History)
19 users (show)

See Also:

Attachments
Patch (22.95 KB, patch)
2022-01-25 15:32 PST, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch (32.35 KB, patch)
2022-01-25 19:25 PST, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2022-01-25 15:27:31 PST 
globalThis.queueMicrotask() should report thrown exceptions
Comment 1 Alexey Shvayka 2022-01-25 15:32:32 PST 
Created attachment 449973 [details]
Patch
Comment 2 Geoffrey Garen 2022-01-25 15:44:32 PST 
Comment on attachment 449973 [details]
Patch

r=me
Comment 3 Mark Lam 2022-01-25 15:53:03 PST 
Comment on attachment 449973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449973&action=review

> Source/WebCore/bindings/js/JSDOMMicrotask.cpp:39
> +class JSDOMMicrotask final : public Microtask {

WTF_MAKE_FAST_ALLOCATED?
Comment 4 Mark Lam 2022-01-25 15:54:36 PST 
Comment on attachment 449973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449973&action=review

>> Source/WebCore/bindings/js/JSDOMMicrotask.cpp:39
>> +class JSDOMMicrotask final : public Microtask {
> 
> WTF_MAKE_FAST_ALLOCATED?

Nevermind.  Since this ultimately inherits from RefCounted, it is already WTF_MAKE_FAST_ALLOCATED.
Comment 5 Alexey Shvayka 2022-01-25 19:25:17 PST 
Created attachment 449992 [details]
Patch

Skip SW test on mac-wk1, reset expectations for inspector test, and remove now unused createJSMicrotask() overload.
Comment 6 Alexey Shvayka 2022-01-26 12:10:23 PST 
Committed r288640 (246451@trunk): <https://commits.webkit.org/246451@trunk>
Comment 7 Radar WebKit Bug Importer 2022-01-26 12:11:20 PST 
<rdar://problem/88088960>
Comment 8 Alexey Shvayka 2022-01-26 12:12:12 PST 
Thank you both!