Bug 235613 - Fix the lldb Color formatter
Summary: Fix the lldb Color formatter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-25 15:17 PST by Simon Fraser (smfr)
Modified: 2022-01-25 17:07 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.56 KB, patch)
2022-01-25 15:17 PST, Simon Fraser (smfr) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-01-25 15:17:01 PST 
Fix the lldb Color formatter
Comment 1 Simon Fraser (smfr) 2022-01-25 15:17:25 PST 
Created attachment 449972 [details]
Patch
Comment 2 Darin Adler 2022-01-25 15:21:23 PST 
Comment on attachment 449972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449972&action=review

> Tools/lldb/lldb_webkit.py:537
> +        # From ColorSpace.h.

Should we add a comment to ColorSpace.h telling anyone who edits that they need to update this too?
Comment 3 Simon Fraser (smfr) 2022-01-25 15:23:56 PST 
Will do.
Comment 4 Simon Fraser (smfr) 2022-01-25 16:00:41 PST 
https://trac.webkit.org/changeset/288587/webkit
Comment 5 Radar WebKit Bug Importer 2022-01-25 16:01:17 PST 
<rdar://problem/88049212>
Comment 6 Sam Weinig 2022-01-25 16:21:08 PST 
Comment on attachment 449972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449972&action=review

>> Tools/lldb/lldb_webkit.py:537
>> +        # From ColorSpace.h.
> 
> Should we add a comment to ColorSpace.h telling anyone who edits that they need to update this too?

"anyone" == "that idiot Sam who has broken this like 10 times now :(" And yes please.
Comment 7 Darin Adler 2022-01-25 17:07:19 PST 
The fact that we don’t generate one or both of these from a single source is just "because we are cowards".